EditProjectDialog and EditUserDialog manages tabs via guiUtils

frontend-js/src/main/js/Configuration.js

@@ -301,6 +301,10 @@ Configuration.prototype.setPrivilegeTypes = function (privilegeTypes) {
   }
 };
 
+/**
+ *
+ * @returns {PrivilegeType[]}
+ */
 Configuration.prototype.getPrivilegeTypes = function () {
   return this._privilegeTypes;
 };

frontend-js/src/main/js/gui/admin/EditProjectDialog.js

@@ -72,7 +72,6 @@ EditProjectDialog.prototype.createGui = function () {
     name: "COMMENTS",
     panelClass: CommentsTab
   });
-  // var element = Functions.createElement({type: "div", style: "margin-top:10px;"});
   self.setCommentsTab(self._panels[0]);
 
   $(".nav-tabs > li > a", self.getElement()).bind("click", function () {

frontend-js/src/main/js/gui/admin/UsersAdminPanel.js

@@ -171,7 +171,7 @@ UsersAdminPanel.prototype._createUsersTableRow = function () {
       }
     }).catch(function (error) {
       GuiConnector.alert(error);
-    }).finally(function(){
+    }).finally(function () {
       GuiConnector.hideProcessing();
     });
   });
@@ -220,7 +220,8 @@ UsersAdminPanel.prototype.getDialog = function (user) {
         type: "div"
       }),
       user: user,
-      customMap: null
+      configuration: self.getConfiguration(),
+      serverConnector: self.getServerConnector()
     });
     self._dialogs[user.getLogin()] = dialog;
     if (user.getLogin() === undefined) {

frontend-js/src/main/js/map/data/User.js

@@ -251,7 +251,7 @@ User.prototype.hasPrivilege = function (type, objectId) {
 /**
  *
  * @param {Object} params
- * @param {number} params.objectId
+ * @param {number} [params.objectId]
  * @param {PrivilegeType} params.type
  * @param {number} [params.value=1]
  */

frontend-js/src/test/js/gui/admin/EditUserDialog-test.js

@@ -13,6 +13,16 @@ var chai = require('chai');
 var assert = chai.assert;
 var expect = chai.expect;
 
+function createEditUserDialog(project, user) {
+  return new EditUserDialog({
+    element: testDiv,
+    project: project,
+    user: user,
+    configuration: helper.getConfiguration(),
+    serverConnector: ServerConnector
+  });
+}
+
 describe('EditUserDialog', function () {
 
   describe('init', function () {
@@ -22,12 +32,7 @@ describe('EditUserDialog', function () {
       var user = new User({});
       return ServerConnector.getProject().then(function (result) {
         project = result;
-        dialog = new EditUserDialog({
-          element: testDiv,
-          project: project,
-          user: user,
-          customMap: null
-        });
+        dialog = createEditUserDialog(project, user);
         return dialog.init();
       }).then(function () {
         assert.equal(0, logger.getWarnings().length);
@@ -45,12 +50,7 @@ describe('EditUserDialog', function () {
       var user = new User({});
       return ServerConnector.getProject().then(function (result) {
         project = result;
-        dialog = new EditUserDialog({
-          element: testDiv,
-          project: project,
-          user: user,
-          customMap: null
-        });
+        dialog = createEditUserDialog(project, user);
         return dialog.init();
       }).then(function () {
         return dialog.checkValidity().then(function () {
@@ -72,12 +72,7 @@ describe('EditUserDialog', function () {
         return ServerConnector.getProject();
       }).then(function (result) {
         project = result;
-        dialog = new EditUserDialog({
-          element: testDiv,
-          project: project,
-          user: user,
-          customMap: null
-        });
+        dialog = createEditUserDialog(project, user);
         return dialog.init();
       }).then(function () {
         return dialog.checkValidity();
@@ -99,12 +94,7 @@ describe('EditUserDialog', function () {
         return ServerConnector.getProject();
       }).then(function (result) {
         project = result;
-        dialog = new EditUserDialog({
-          element: testDiv,
-          project: project,
-          user: user,
-          customMap: null
-        });
+        dialog = createEditUserDialog(project, user);
         return dialog.init();
       }).then(function () {
         return dialog.onSaveClicked();
@@ -127,12 +117,7 @@ describe('EditUserDialog', function () {
         return ServerConnector.getProject();
       }).then(function (result) {
         project = result;
-        dialog = new EditUserDialog({
-          element: testDiv,
-          project: project,
-          user: user,
-          customMap: null
-        });
+        dialog = createEditUserDialog(project, user);
         return dialog.init();
       }).then(function () {
         return $("[name=privilege-checkbox]", dialog.getElement()).click();
@@ -156,12 +141,7 @@ describe('EditUserDialog', function () {
         return ServerConnector.getProject();
       }).then(function (result) {
         project = result;
-        dialog = new EditUserDialog({
-          element: testDiv,
-          project: project,
-          user: user,
-          customMap: null
-        });
+        dialog = createEditUserDialog(project, user);
         return dialog.init();
       }).then(function () {
         $("[name=privilege-int]", dialog.getElement()).val("101010");