Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • C core
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 93
    • Issues 93
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • minervaminerva
  • core
  • Merge requests
  • !771

Resolve "wrong start and end of reaction lines"

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Piotr Gawron requested to merge 812-wrong-start-and-end-of-reaction-lines into master May 13, 2019
  • Overview 0
  • Commits 14
  • Pipelines 3
  • Changes 13

Closes #812 (closed) dear @david.hoksza,

This MR should resolve the problem. The root cause was ignoring layout of reaction with single line segment (in reaction part) when there were more than one product or more than one reactant.

However I found inconsistency in your SBML layout file. According to SBML specification(http://tinyurl.com/sbml-layout-rc2):

“product”, “sideproduct”, “substrate”, “sidesubstrate”, “undefined”: The line segments have their start element at the ReactionGlyph and their end element at the SpeciesGlyph.

But the point order in the submitted SBML file is reversed.

Edited May 13, 2019 by Piotr Gawron
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 812-wrong-start-and-end-of-reaction-lines