Skip to content
Snippets Groups Projects

Resolve "Rest API should follow google guidlines"

Merged Piotr Gawron requested to merge 90-rest-api-should-follow-google-guidlines into master
1 file
+ 15
19
Compare changes
  • Side-by-side
  • Inline
@@ -482,20 +482,15 @@ ServerConnector.getIdOrAsterisk = function(id) {
}
}
ServerConnector.getAliasesUrl = function(params) {
var id = this.idsToString(params.ids);
var columns = this.columnsToString(params.columns);
var projectId = params.projectId;
var token = params.token;
var modelId = this.getIdOrAsterisk(params.modelId);
ServerConnector.getAliasesUrl = function(queryParams, filterParams) {
var params = {};
params.id = this.idsToString(filterParams.ids);
params.columns = this.columnsToString(filterParams.columns);
params.token = filterParams.token;
return this.getApiUrl({
url : this.getBioEntitiesUrl(params) + "elements/",
params : {
columns : columns,
id : id,
token : token
},
url : this.getBioEntitiesUrl(queryParams) + "elements/",
params : params,
});
};
@@ -982,16 +977,17 @@ ServerConnector.getReactions = function(params) {
ServerConnector.getAliases = function(aliasIds, projectId, columns) {
var self = this;
var queryParams = {};
var filterParams = {
ids : aliasIds,
columns : columns
};
return self.getProjectId(projectId).then(function(result) {
projectId = result;
queryParams.projectId = result;
return self.getToken();
}).then(function(token) {
return self.readFile(self.getAliasesUrl({
ids : aliasIds,
projectId : projectId,
token : token,
columns : columns
}));
filterParams.token = token;
return self.readFile(self.getAliasesUrl(queryParams, filterParams));
}).then(function(content) {
var array = JSON.parse(content);
var result = [];
Loading