Resolve "Rest API should follow google guidlines"

Closes #90 (closed)

frontend-js/src/main/js/ServerConnector.js

@@ -215,7 +215,10 @@ ServerConnector.getApiUrl = function(paramObj) {
   var method = paramObj.method;
   var params = this.createGetParams(paramObj.params);
 
-  var result = this.getApiBaseUrl() + "/" + type + "/" + method;
+  var result = this.getApiBaseUrl() + "/" + type;
+  if (method !== undefined) {
+    result += "/" + method;
+  }
   if (params !== "") {
     result += "?" + params;
   }
@@ -1291,61 +1294,55 @@ ServerConnector.addComment = function(params) {
 
 ServerConnector.addOverlay = function(params) {
   var self = this;
-  return new Promise(function(resolve, reject) {
-    return self.getProjectId(params.projectId).then(function(result) {
-      params.projectId = result;
-      return self.getToken();
-    }).then(function(token) {
-      params.token = token;
-      return self.sendPostRequest(self.addOverlayUrl(), params);
-    }).then(function(content) {
-      var response = JSON.parse(content);
-      if (response.status === "OK") {
-        resolve(response.overlayId);
-      } else {
-        reject(response);
-      }
-    });
+  return self.getProjectId(params.projectId).then(function(result) {
+    params.projectId = result;
+    return self.getToken();
+  }).then(function(token) {
+    params.token = token;
+    return self.sendPostRequest(self.addOverlayUrl(), params);
+  }).then(function(content) {
+    var response = JSON.parse(content);
+    if (response.status === "OK") {
+      return response.overlayId;
+    } else {
+      return Promise.reject(response);
+    }
   });
 };
 
 ServerConnector.updateOverlay = function(params) {
   var self = this;
-  return new Promise(function(resolve, reject) {
-    return self.getProjectId(params.projectId).then(function(result) {
-      params.projectId = result;
-      return self.getToken();
-    }).then(function(token) {
-      params.token = token;
-      return self.sendPostRequest(self.updateOverlayUrl(), params);
-    }).then(function(content) {
-      var response = JSON.parse(content);
-      if (response.status === "OK") {
-        resolve();
-      } else {
-        reject(response.reason);
-      }
-    });
+  return self.getProjectId(params.projectId).then(function(result) {
+    params.projectId = result;
+    return self.getToken();
+  }).then(function(token) {
+    params.token = token;
+    return self.sendPostRequest(self.updateOverlayUrl(), params);
+  }).then(function(content) {
+    var response = JSON.parse(content);
+    if (response.status === "OK") {
+      return Promise.resolve();
+    } else {
+      return Promise.reject(response.reason);
+    }
   });
 };
 
 ServerConnector.removeOverlay = function(params) {
   var self = this;
-  return new Promise(function(resolve, reject) {
-    return self.getProjectId(params.projectId).then(function(result) {
-      params.projectId = result;
-      return self.getToken();
-    }).then(function(token) {
-      params.token = token;
-      return self.sendPostRequest(self.deleteOverlayUrl(), params);
-    }).then(function(content) {
-      var response = JSON.parse(content);
-      if (response.status === "OK") {
-        resolve();
-      } else {
-        reject(response);
-      }
-    });
+  return self.getProjectId(params.projectId).then(function(result) {
+    params.projectId = result;
+    return self.getToken();
+  }).then(function(token) {
+    params.token = token;
+    return self.sendPostRequest(self.deleteOverlayUrl(), params);
+  }).then(function(content) {
+    var response = JSON.parse(content);
+    if (response.status === "OK") {
+      return Promise.resolve();
+    } else {
+      return Promise.reject(response);
+    }
   });
 };