error handling in plugin loa improved (when plugins crash)

frontend-js/src/main/js/plugin/Plugin.js

@@ -135,10 +135,16 @@ Plugin.prototype.unload = function () {
 };
 
 Plugin.prototype.getName = function () {
+  if (this.getLoadedPluginData() === undefined) {
+    return "";
+  }
   return this.getLoadedPluginData().getName();
 };
 
 Plugin.prototype.getVersion = function () {
+  if (this.getLoadedPluginData() === undefined) {
+    return "";
+  }
   return this.getLoadedPluginData().getVersion();
 };
 

frontend-js/src/test/js/plugin/Plugin-test.js

@@ -62,7 +62,7 @@ describe('Plugin', function () {
       return plugin.load().then(function () {
         assert.notOk("expected error");
       }, function (error) {
-        assert.ok(error.message.indexOf("Unexpected identifier") >= 0);
+        assert.ok(error.message.indexOf("Unexpected identifier") >= 0, "Wrong message: " + error.message);
       });
     });
 
@@ -75,7 +75,7 @@ describe('Plugin', function () {
       return plugin.load().then(function () {
         assert.false("expected error");
       }, function (error) {
-        assert.ok(error.message.indexOf("Let's crash") >= 0);
+        assert.ok(error.message.indexOf("Let's crash") >= 0, "Wrong message: " + error.message);
       });
     });
     it('plugin register promise reject', function () {
@@ -86,8 +86,8 @@ describe('Plugin', function () {
       });
       return plugin.load().then(function () {
         assert.false("expected error");
-      }, function (error) {
-        assert.ok(error.message.indexOf("Let's reject") >= 0);
+      }).catch( function (error) {
+        assert.ok(error.message.indexOf("Let's reject") >= 0, "Wrong message: " + error.message);
       });
     });
   });

frontend-js/testFiles/apiCalls/plugins/POST_hash=273dffdc94ef22531b90fb4489ba00c3&name=plugin%20with%20promise&url=.%2FtestFiles%2Fplugin-invalid%2Fresult-promise-crash.js&version=0.0.1&token=MOCK_TOKEN_ID&

+{
+    "hash": "273dffdc94ef22531b90fb4489ba00c3",
+    "name": "plugin with promise",
+    "urls": [
+        "./testFiles/plugin-invalid/result-promise-crash.js"
+    ],
+    "version": "0.0.1"
+}
\ No newline at end of file

frontend-js/testFiles/apiCalls/plugins/POST_hash=c36d817fb1e6c3a7b569ee9ba55baa76&url=.%2FtestFiles%2Fplugin-invalid%2Finvalid_javascript.js&token=MOCK_TOKEN_ID&

+{
+    "hash": "c36d817fb1e6c3a7b569ee9ba55baa76",
+    "name": "",
+    "urls": [
+        "./testFiles/plugin-invalid/invalid_javascript.js"
+    ],
+    "version": ""
+}
\ No newline at end of file

frontend-js/testFiles/apiCalls/plugins/POST_hash=d5d652ac0e0f6467d4cb6a742f99d3f7&name=test%20plugin&url=.%2FtestFiles%2Fplugin-invalid%2Finvalid_register.js&version=0.0.1&token=MOCK_TOKEN_ID&

+{
+    "hash": "d5d652ac0e0f6467d4cb6a742f99d3f7",
+    "name": "test plugin",
+    "urls": [
+        "./testFiles/plugin-invalid/invalid_register.js"
+    ],
+    "version": "0.0.1"
+}
\ No newline at end of file