Skip to content
Snippets Groups Projects

Feature/add way to change password and PERMISSIONS

Merged Carlos Vega requested to merge feature/add_way_to_change_password into master
All threads resolved!

Closes #272 (closed) and #31 (closed)

I put the WIP prefix because I guess we will have to test some features first and decide which permissions we should set.

Edited by Piotr Gawron

Merge request reports

Pipeline #7747 passed

Pipeline passed for 671e1120 on feature/add_way_to_change_password

Test coverage 91.41% from 1 job

Merged by Piotr GawronPiotr Gawron 6 years ago (Dec 11, 2018 8:00am UTC)

Merge details

Pipeline #7821 passed

Pipeline passed for ce5093ff on master

Test coverage 91.41% from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Piotr Gawron
  • Piotr Gawron assigned to @carlos.vega

    assigned to @carlos.vega

  • Carlos Vega added 4 commits

    added 4 commits

    • d6982008 - get or create appointment_type 'other'
    • 9fd793b8 - properly used conf_perms to hide or show configuration based on the worker permissions
    • d0fd4b42 - removed comment
    • fbf5fea5 - refactor as Piotr proposed

    Compare with previous version

  • Carlos Vega added 1 commit

    added 1 commit

    Compare with previous version

  • Carlos Vega added 1 commit

    added 1 commit

    Compare with previous version

  • Please add in the worker details form information if the user is super admin. Maybe small (?) with information that in such case all privileges are granted to the user.

  • Carlos Vega added 2 commits

    added 2 commits

    Compare with previous version

  • Piotr Gawron
  • Piotr Gawron assigned to @carlos.vega

    assigned to @carlos.vega

  • I also propose for future issues:

    Change 403 forbidden instead of 302 to differentiate usual redirect from no-permissions problems. Create permission to list objects (vouchers, workers, languages, etc)

  • Carlos Vega added 7 commits

    added 7 commits

    • fd21d8bb - show if worker is super user
    • 9541d97f - added decorator to worker listing view method
    • 7aa15f11 - added the missing @
    • cf945719 - added support for class-based views
    • 6037223b - consider voucher permission
    • 805c4faf - added decorators properly in class-based views
    • 448c4e1c - updated view and form tests

    Compare with previous version

  • Carlos Vega added 22 commits

    added 22 commits

    Compare with previous version

  • Piotr Gawron unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Login doesn't work in a situation when user doesn't have access to some page but tries to access it before logging in.

    To better understand let me give an example. We have user 'test' that doesn't have access to languages subpage. Now open incognito window (so you are not logged in) and try to access page: http://localhost:8000/languages. This redirects you to login page, which is perfectly normal. Now after providing correct login and password nothing happens (at least it looks that way, because from undergoing http calls you can see that login was successful but redirection was denied so you ended up at the login page with no error information)

  • mentioned in issue #279 (closed)

  • Carlos Vega resolved all discussions

    resolved all discussions

  • The problem is that the decorator returns to the referer. I found no safe way to check if the referer is the login page or not other than a string contains comparison to check if the url contains /account/login. Instead, what I did, is that the login template, if it founds the user is already authenticated, will redirect the user to the index page.

  • closed

  • reopened

  • Carlos Vega added 1 commit

    added 1 commit

    Compare with previous version

  • Piotr Gawron mentioned in commit ce5093ff

    mentioned in commit ce5093ff

  • merged

  • Please register or sign in to reply
    Loading