voucher model modified

Voucher number follow naming schema: {ND_NUMBER}-{DATE}-{VOUCHER_TYPE_CODE}-{VOUCHER_PARTNER_CODE}-{SEQ_NUMBER}{CHECKSUM}

Single voucher is issued for some hours to be used. These hours can be used in few sessions by corresponding voucher partner.

Closes #211 (closed)

added 2 commits

• 0bd6e0d2 - voucher partner is obligatory in voucher, voucher number is generated using schema
• 715564e8 - single voucher can be used in few sessions at voucher partner

Compare with previous version

unmarked as a Work In Progress

changed title from WIP: Resolve "voucher data" to voucher model modified

changed the description

assigned to @valentin.groues

we use https://github.com/takeflight/django-enumchoicefield for DAISY and we are very happy with it, maybe worth considering a refactoring to replace all the django CHOICES fields

We could think about it, but it's for python3. We should switch to python3 before any changes like that.

can also be replaced with a in []

fixed here: 7949ed91

But I don't like it. The syntax for me look wrong. There is no indication that we iterate over a list, and comma inside string as a separator looks simply wrong:

   {% if voucher.status in 'NEW,IN_USE' %}

Oh, indeed it’s was not a good suggestion for the template actually. sorry. I didn’t know you cannot use in [‘NEW’ , ‘IN_USE’] in django templates (in flask it’s possible). apparently, it’s possible to use in my_list and to pass the my_list variable as a template context variable. not sure if it’s better though.

Valentin Grouès

Bioinformatics Core Luxembourg Centre For Systems Biomedicine (LCSB)

University of Luxembourg Campus Belval | House of Biomedicine 2 6, avenue du Swing L-4367 Belvaux

T +352 46 66 44 9646 F +352 46 66 44 3 9646 valentin.groues@uni.lu mailto:valentin.groues@uni.lu http://lcsb.uni.lu http://lcsb.uni.lu/

smime.p7s

Hi,

Is it expected that when I try to create voucher partners, they are disabled?

added 1 commit

• 7949ed91 - multiple === operators changed into "in" operator

Compare with previous version

Disabled means that person cannot log in. So the value is correct. The thing is that voucher partners shouldn't be able to log in at all. So in this context it shouldn't be visible.

the help message still mentions contact attempt on the add price button ;)

with this merge request is there a way to already create a voucher with the UI?

Yes, but you need to change single parameter in the database:

update web_studycolumns set vouchers=true, voucher_types=true where id in (select id from web_study);

Now you should have access to add voucher button in the subject page.

thanks, I have the button now (maybe it could be hidden for diseases and resigned subjects?). However, the list of voucher types is empty. I think that's because my db table web_studysubject_voucher_types is empty. Should I add something there?

You can do it in Configuration->Voucher types

ok, thanks. beside my minor comments above, it looks good I think.

mentioned in commit e0d00b85

merged

mentioned in merge request !141 (merged)