Skip to content
Snippets Groups Projects
Commit 7f9a91c7 authored by Piotr Gawron's avatar Piotr Gawron
Browse files

settings parameter names unified

parent 44fe7a81
No related branches found
No related tags found
1 merge request!238Tns update
...@@ -23,14 +23,14 @@ class ExporterCronJob(CronJobBase): ...@@ -23,14 +23,14 @@ class ExporterCronJob(CronJobBase):
email_title = "Daily export" email_title = "Daily export"
email_recipients = getattr(settings, "DEFAULT_FROM_EMAIL", None) email_recipients = getattr(settings, "DEFAULT_FROM_EMAIL", None)
filename = getattr(settings, "DAILY_EXPORT_FILE", None) filename = getattr(settings, "DAILY_SUBJECT_EXPORT_FILE", None)
if filename is None: if filename is None:
logger.info("Exporting subjects skipped. File not defined ") logger.info("Exporting subjects skipped. File not defined ")
return "export file not defined" return "export file not defined"
logger.info("Exporting subjects from file: " + filename) logger.info("Exporting subjects from file: " + filename)
try: try:
exporter = Exporter(settings.DAILY_EXPORT_FILE) exporter = Exporter(settings.DAILY_SUBJECT_EXPORT_FILE)
exporter.execute() exporter.execute()
email_body = exporter.get_summary() email_body = exporter.get_summary()
EmailSender().send_email(email_title, EmailSender().send_email(email_title,
......
...@@ -28,7 +28,7 @@ class SubjectImporterCronJob(CronJobBase): ...@@ -28,7 +28,7 @@ class SubjectImporterCronJob(CronJobBase):
email_title = "Subjects daily import" email_title = "Subjects daily import"
email_recipients = getattr(settings, "DEFAULT_FROM_EMAIL", None) email_recipients = getattr(settings, "DEFAULT_FROM_EMAIL", None)
filename = getattr(settings, "DAILY_IMPORT_FILE", None) filename = getattr(settings, "DAILY_SUBJECT_IMPORT_FILE", None)
if filename is None: if filename is None:
logger.info("Importing subjects skipped. File not defined ") logger.info("Importing subjects skipped. File not defined ")
...@@ -40,7 +40,7 @@ class SubjectImporterCronJob(CronJobBase): ...@@ -40,7 +40,7 @@ class SubjectImporterCronJob(CronJobBase):
email_recipients) email_recipients)
return "import file not found" return "import file not found"
try: try:
importer = Importer(settings.DAILY_IMPORT_FILE, TnsCsvSubjectImportReader()) importer = Importer(settings.DAILY_SUBJECT_IMPORT_FILE, TnsCsvSubjectImportReader())
importer.execute() importer.execute()
email_body = importer.get_summary() email_body = importer.get_summary()
EmailSender().send_email(email_title, EmailSender().send_email(email_title,
......
...@@ -16,10 +16,10 @@ from django_cron.models import CronJobLog ...@@ -16,10 +16,10 @@ from django_cron.models import CronJobLog
class TestCronJobExporter(TestCase): class TestCronJobExporter(TestCase):
def setUp(self): def setUp(self):
setattr(settings, "DAILY_EXPORT_FILE", None) setattr(settings, "DAILY_SUBJECT_EXPORT_FILE", None)
def tearDown(self): def tearDown(self):
setattr(settings, "DAILY_EXPORT_FILE", None) setattr(settings, "DAILY_SUBJECT_EXPORT_FILE", None)
def test_import_without_configuration(self): def test_import_without_configuration(self):
CronJobLog.objects.all().delete() CronJobLog.objects.all().delete()
...@@ -34,7 +34,7 @@ class TestCronJobExporter(TestCase): ...@@ -34,7 +34,7 @@ class TestCronJobExporter(TestCase):
def test_import(self): def test_import(self):
new_file, tmp = tempfile.mkstemp() new_file, tmp = tempfile.mkstemp()
setattr(settings, "DAILY_EXPORT_FILE", tmp) setattr(settings, "DAILY_SUBJECT_EXPORT_FILE", tmp)
CronJobLog.objects.all().delete() CronJobLog.objects.all().delete()
job = ExporterCronJob() job = ExporterCronJob()
......
...@@ -18,7 +18,7 @@ from django_cron.models import CronJobLog ...@@ -18,7 +18,7 @@ from django_cron.models import CronJobLog
class TestCronJobImporter(TestCase): class TestCronJobImporter(TestCase):
def tearDown(self): def tearDown(self):
setattr(settings, "DAILY_IMPORT_FILE", None) setattr(settings, "DAILY_SUBJECT_IMPORT_FILE", None)
def test_import_without_configuration(self): def test_import_without_configuration(self):
CronJobLog.objects.all().delete() CronJobLog.objects.all().delete()
...@@ -35,7 +35,7 @@ class TestCronJobImporter(TestCase): ...@@ -35,7 +35,7 @@ class TestCronJobImporter(TestCase):
new_file, tmp = tempfile.mkstemp() new_file, tmp = tempfile.mkstemp()
copyfile(filename, tmp) copyfile(filename, tmp)
setattr(settings, "DAILY_IMPORT_FILE", tmp) setattr(settings, "DAILY_SUBJECT_IMPORT_FILE", tmp)
CronJobLog.objects.all().delete() CronJobLog.objects.all().delete()
job = SubjectImporterCronJob() job = SubjectImporterCronJob()
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment