Skip to content
Snippets Groups Projects
Commit 7a31738e authored by Valentin Groues's avatar Valentin Groues :eyes:
Browse files

app was crashing when adding a visit without end or/and start date

parent 482b2e67
No related branches found
No related tags found
No related merge requests found
Pipeline #
......@@ -228,9 +228,12 @@ class VisitAddForm(ModelForm):
exclude = ['is_finished']
def clean(self):
super(VisitAddForm, self).clean()
if 'datetime_begin' not in self.cleaned_data or 'datetime_end' not in self.cleaned_data:
return
if self.cleaned_data['datetime_begin'] >= self.cleaned_data['datetime_end']:
self.add_error('datetime_begin', "Start date must be before end date")
self.add_error('datetime_end', "Start date must be before end date")
self.add_error('datetime_end', "End date must be after start date")
class KitRequestForm(Form):
......
......@@ -33,3 +33,9 @@ class SubjectAddFormTests(TestCase):
self.assertFalse(validation_status)
self.assertTrue("datetime_begin" in form.errors)
self.assertTrue("datetime_end" in form.errors)
def test_invalid_no_dates(self):
self.sample_data.pop('datetime_begin')
form = VisitAddForm(data=self.sample_data)
validation_status = form.is_valid()
self.assertFalse(validation_status)
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment