modif_flyingteam permission implemented

smash/web/templates/sidebar.html

@@ -48,7 +48,9 @@
             {% if "change_appointmenttype" in permissions %}
                 <li data-desc="appointment_types"><a href="{% url 'web.views.appointment_types' %}">Appointment Types</a></li>
             {% endif %}
+            {% if "change_flyingteam" in permissions %}
                 <li data-desc="flying_teams"><a href="{% url 'web.views.equipment_and_rooms.flying_teams' %}">Flying teams</a></li>
+            {% endif %}
                 <li data-desc="kit_requests"><a href="{% url 'web.views.kit_requests' %}">Kit requests</a></li>
                 <li data-desc="rooms"><a href="{% url 'web.views.equipment_and_rooms.rooms' %}">Rooms</a></li>
         </ul>

smash/web/tests/view/test_flying_teams.py

@@ -17,6 +17,7 @@ class FlyingTeamTests(LoggedInTestCase):
         return 'Random' + ''.join(random.choice(letters) for x in range(15))
 
     def test_flying_team_requests(self):
+        self.login_as_admin()
         pages = [
             'web.views.equipment_and_rooms.flying_teams',
             'web.views.equipment_and_rooms.flying_teams_add',
@@ -26,7 +27,18 @@ class FlyingTeamTests(LoggedInTestCase):
             response = self.client.get(reverse(page))
             self.assertEqual(response.status_code, 200)
 
+    def test_flying_team_requests_without_permission(self):
+        pages = [
+            'web.views.equipment_and_rooms.flying_teams',
+            'web.views.equipment_and_rooms.flying_teams_add',
+        ]
+
+        for page in pages:
+            response = self.client.get(reverse(page))
+            self.assertEqual(response.status_code, 302)
+
     def test_flying_team_add(self):
+        self.login_as_admin()
         page = reverse('web.views.equipment_and_rooms.flying_teams_add')
         data = {
             'place': self.generate_more_or_less_random_name()
@@ -38,6 +50,7 @@ class FlyingTeamTests(LoggedInTestCase):
         self.assertEqual(len(freshly_created), 1)
 
     def test_flying_team_edit(self):
+        self.login_as_admin()
         flying_team = create_flying_team()
         page = reverse('web.views.equipment_and_rooms.flying_teams_edit',
                        kwargs={'flying_team_id': str(flying_team.id)})
@@ -51,6 +64,7 @@ class FlyingTeamTests(LoggedInTestCase):
         self.assertEqual(freshly_edited.place, data["place"])
 
     def test_flying_team_edit_request(self):
+        self.login_as_admin()
         flying_team = create_flying_team()
         page = reverse('web.views.equipment_and_rooms.flying_teams_edit',
                        kwargs={'flying_team_id': str(flying_team.id)})

smash/web/views/flying_teams.py

 # coding=utf-8
 from django.shortcuts import redirect, get_object_or_404
 
+from web.decorators import PermissionDecorator
 from . import wrap_response
-from ..models import FlyingTeam
 from ..forms.forms import FlyingTeamAddForm, FlyingTeamEditForm
+from ..models import FlyingTeam
 
 
+@PermissionDecorator('change_flyingteam', 'item')
 def flying_teams(request):
     flying_team_list = FlyingTeam.objects.order_by('-place')
     context = {
@@ -16,6 +18,8 @@ def flying_teams(request):
                          "equipment_and_rooms/flying_teams/index.html",
                          context)
 
+
+@PermissionDecorator('change_flyingteam', 'item')
 def flying_teams_add(request):
     if request.method == 'POST':
         form = FlyingTeamAddForm(request.POST)
@@ -28,6 +32,7 @@ def flying_teams_add(request):
     return wrap_response(request, 'equipment_and_rooms/flying_teams/add.html', {'form': form})
 
 
+@PermissionDecorator('change_flyingteam', 'item')
 def flying_teams_edit(request, flying_team_id):
     the_flying_team = get_object_or_404(FlyingTeam, id=flying_team_id)
     if request.method == 'POST':