feat: add legend for active overlays
1 unresolved thread
1 unresolved thread
Closes MIN-196
Objective
Display list of overlays legends along with theirs names in the overlays drawer
What has been done:
- implementation of overlays legends in the overlays drawer
- unit tests
Merge request reports
Activity
Filter activity
assigned to @AdrianOrlow
21 return ( 22 render( 23 <Wrapper> 24 <OverlaysLegends /> 25 </Wrapper>, 26 ), 27 { 28 store, 29 } 30 ); 31 }; 32 33 describe('OverlaysLegends - component', () => { 34 describe('when active overlays are empty', () => { 35 beforeEach(() => { 36 activeOverlaysSelectorMock.mockImplementation(() => []); -
Not fan of this solution. This way you are making unit tests but for components connected to redux it's almost 100% of the time preferred to use integrational tests. When you make changes to the store and selector without changing name of the selector -> you might end with false negative test. Code would not work but test would pass.
changed this line in version 4 of the diff
added 18 commits
-
6b498119...0fde397d - 17 commits from branch
development - dfc20140 - Merge branch 'development' into MIN-196-display-legend-in-drawer-for-active-overlays
-
6b498119...0fde397d - 17 commits from branch
enabled an automatic merge when the pipeline for 45ca304f succeeds
mentioned in commit 5f0d2e38
Please register or sign in to reply