Skip to content
Snippets Groups Projects

Resolve MIN-136 "Feat/ appearance of layer editing"

Merged Resolve MIN-136 "Feat/ appearance of layer editing"
feat/MIN-136-appearance-of-layer-editing into development
2 unresolved threads
Merged Miłosz Grocholewski requested to merge feat/MIN-136-appearance-of-layer-editing into development
2 unresolved threads

Closes MIN-136

Merge request reports

Merge request pipeline #101438 passed

Stage: lint
    Stage: prettier
      Stage: test

        Merge request pipeline passed for 7c56afaf

        Test coverage 83.71% (-0.62%) from 1 job
        Approval is optional
        Ready to merge by members who can write to the target branch.

        Merge details

        • 1 commit and 1 merge commit will be added to development (squashes 1 commit).
        • Source branch will be deleted.

        • Closes issue MIN-136

        Activity

        Filter activity
        • Approvals
        • Assignees & reviewers
        • Comments (from bots)
        • Comments (from users)
        • Commits & branches
        • Edits
        • Labels
        • Lock status
        • Mentions
        • Merge request status
        • Tracking
        src/components/Map/Drawer/LayersDrawer/LayerDrawerLayerContextMenu.component.tsx 0 → 100644
        8 addImage: () => void;
        9 addText: () => void;
        10 };
        11
        12 export const LayerDrawerLayerContextMenu = ({
        13 removeLayer,
        14 editLayer,
        15 addImage,
        16 addText,
        17 }: LayerDrawerLayerContextMenuProps): JSX.Element => {
        18 const [menuVisible, setMenuVisible] = useState(false);
        19 const menuRef = useRef<HTMLUListElement>(null);
        20 const dotsRef = useRef<HTMLDivElement>(null);
        21
        22 const toggleMenu = (): void => {
        23 setMenuVisible(prev => !prev);
      • Konrad Przybysz
        Konrad Przybysz @KonradAt started a thread on an old version of the diff
        • src/components/Map/Drawer/LayersDrawer/LayerDrawerLayerContextMenu.component.tsx 0 → 100644
        47 <div className="relative inline-block">
        48 <div ref={dotsRef}>
        49 <IconButton
        50 icon="dots"
        51 title="Switch visibility"
        52 className="h-auto w-auto bg-transparent p-0"
        53 onClick={toggleMenu}
        54 />
        55 </div>
        56
        57 {menuVisible && (
        58 <ul
        59 ref={menuRef}
        60 className="absolute right-[24px] top-[-14px] z-[1] mt-2 w-[11rem] rounded border bg-white p-2 shadow-md"
        61 >
        62 <li
      • Konrad Przybysz
        Konrad Przybysz @KonradAt ·
        Developer

        image

        value of locked and visible are not passed to edit layer modal

      • Konrad Przybysz
        Konrad Przybysz @KonradAt ·
        Developer

        i would block selecting compartments when edit menu is open

      • Konrad Przybysz requested changes

        requested changes

      • Miłosz Grocholewski added 17 commits

        added 17 commits

        Compare with previous version

      • Miłosz Grocholewski added 1 commit

        added 1 commit

        • 7c56afaf - feat(layers): separate component for layer context menu items

        Compare with previous version

      • Konrad Przybysz approved this merge request

        approved this merge request

      • Miłosz Grocholewski merged

        merged

      • Miłosz Grocholewski mentioned in commit 288461d5

        mentioned in commit 288461d5

        • Please register or sign in to reply