Skip to content
Snippets Groups Projects

feat: search drawer stepper (MIN-97)

Merged mateuszmiko requested to merge feature/MIN-97-search-drawer-stepper into development
All threads resolved!

Objective:

Add a search drawer wrapper that is used to change the component according to the current step and value type in the drawer.

What has been done:

  • Added SearchComponentWrapper with tests
Edited by mateuszmiko

Merge request reports

Merge request pipeline #79802 passed

Merge request pipeline passed for 3a3f0833

Test coverage 83.78% (0.62%) from 1 job

Merged by mateuszmikomateuszmiko 1 year ago (Oct 16, 2023 2:09pm UTC)

Loading

Pipeline #79803 passed

Pipeline passed for 3a6501ff on development

Test coverage 83.78% (0.62%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Hey, I think you need rethink usage of drawer reducer. It's RFC from my side

  • mateuszmiko resolved all threads

    resolved all threads

  • mateuszmiko added 1 commit

    added 1 commit

    • 7d3e3b43 - feat(search drawer state): create new reducer for search drawer state

    Compare with previous version

  • mateuszmiko added 1 commit

    added 1 commit

    • 2e8f30db - feat(search drawer stepper): create setSearchDrawerState and clearSearchDrawerState functions

    Compare with previous version

  • LGTM but resolving the issue with FIRST_STEP etc. is an RFC

  • Adrian Orłów approved this merge request

    approved this merge request

  • mateuszmiko added 1 commit

    added 1 commit

    • 6e212fd9 - feat(search drawer stepper): extract const variables to constatns

    Compare with previous version

  • mateuszmiko resolved all threads

    resolved all threads

  • mateuszmiko enabled an automatic merge when the pipeline for 6e212fd9 succeeds

    enabled an automatic merge when the pipeline for 6e212fd9 succeeds

  • mateuszmiko aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • mateuszmiko added 9 commits

    added 9 commits

    Compare with previous version

  • mateuszmiko enabled an automatic merge when the pipeline for 3a3f0833 succeeds

    enabled an automatic merge when the pipeline for 3a3f0833 succeeds

  • merged

  • mateuszmiko mentioned in commit 3a6501ff

    mentioned in commit 3a6501ff

  • Please register or sign in to reply
    Loading