Skip to content
Snippets Groups Projects

Resolve MIN-96 "Feature/ open drawer after search"

Merged Resolve MIN-96 "Feature/ open drawer after search"
feature/MIN-96-open-drawer-after-search into development
2 unresolved threads
Merged Tadeusz Miesiąc requested to merge feature/MIN-96-open-drawer-after-search into development
2 unresolved threads

Description

In this PR I introduce functionality: When users triggers search query -> open drawer and show content image image

Things done

  • Open drawer on search query start
  • Display drugs drawer with loading indicator or number of drugs results depending on request status

Additional

  • Introduced more general redux wrapper that allow you to mock initial state

Merge request reports

Merge request pipeline #79671 passed

Stage: lint
    Stage: prettier
      Stage: test

        Merge request pipeline passed for 8c466924

        Test coverage 82.51% (6.98%) from 1 job
        Approval is optional

        Merged by Tadeusz MiesiącTadeusz Miesiąc 1 year ago (Oct 13, 2023 12:59pm UTC)

        Merge details

        • Changes merged into development with 8f6bfc26.
        • Deleted the source branch.

        • Closed MIN-96

        • Auto-merge enabled

        Pipeline #79677 failed

        Stage: lint
          Stage: prettier
            Stage: test
              Stage: deploy

                Pipeline failed for 8f6bfc26 on development

                Test coverage 82.52% (6.98%) from 1 job

                Activity

                Filter activity
                • Approvals
                • Assignees & reviewers
                • Comments (from bots)
                • Comments (from users)
                • Commits & branches
                • Edits
                • Labels
                • Lock status
                • Mentions
                • Merge request status
                • Tracking
                src/shared/Accordion/AccordionItemButton/AccordionItemButton.component.tsx
                15 'non-expandable': <Icon name="chevron-right" className="h-6 w-6 fill-font-500" />,
                16 };
                17
                18 return variantsIcons[variant];
                19 };
                20
                21 export const AccordionItemButton = ({
                22 children,
                23 variant = 'expandable',
                24 }: AccordionItemButtonProps): JSX.Element => {
                25 const ButtonIcon = getIcon(variant);
                26
                27 return (
                28 <AIB className="accordion-button flex flex-row flex-nowrap justify-between">
                29 {children}
                30 {/* <Icon name="chevron-down" className="arrow-button h-6 w-6 fill-font-500" /> */}
              • mateuszmiko approved this merge request

                approved this merge request

              • Adrian Orłów
                Adrian Orłów @AdrianOrlow started a thread on an old version of the diff
                • src/shared/Accordion/AccordionItemButton/AccordionItemButton.component.tsx
                2 3 import { AccordionItemButton as AIB } from 'react-accessible-accordion';
                3 4 import './AccordionItemButton.style.css';
                4 5
                6 type Variant = 'expandable' | 'non-expandable';
                5 7 interface AccordionItemButtonProps {
                6 8 children: React.ReactNode;
                9 variant?: Variant;
                7 10 }
                8 11
                9 export const AccordionItemButton = ({ children }: AccordionItemButtonProps): JSX.Element => (
                10 <AIB className="accordion-button flex flex-row flex-nowrap justify-between">
                11 {children}
                12 <Icon name="chevron-down" className="arrow-button h-6 w-6 fill-font-500" />
                13 </AIB>
                14 );
                12 const getIcon = (variant: Variant): JSX.Element => {
              • Adrian Orłów
                Adrian Orłów @AdrianOrlow ·
                Developer

                LGTM

              • Adrian Orłów approved this merge request

                approved this merge request

              • Tadeusz Miesiąc added 1 commit

                added 1 commit

                • 8c466924 - refactor(accordion item button): moved helpers to separate file

                Compare with previous version

              • Tadeusz Miesiąc enabled an automatic merge when the pipeline for 8c466924 succeeds

                enabled an automatic merge when the pipeline for 8c466924 succeeds

              • Tadeusz Miesiąc mentioned in commit 8f6bfc26

                mentioned in commit 8f6bfc26

              • Tadeusz Miesiąc merged

                merged

                • Please register or sign in to reply