Skip to content
Snippets Groups Projects

Resolve MIN-57 "Feature/ connect drug search query"

Merged Resolve MIN-57 "Feature/ connect drug search query"
feature/MIN-57-connect-drug-search-query into development
Merged Tadeusz Miesiąc requested to merge feature/MIN-57-connect-drug-search-query into development

Description

Introduced fetching for drugs query

Things done

  • fetching
  • saving to redux store under 'drugs'
  • initialised integrational testing for redux
  • introduced axios mock library
  • introduced utility functions for mocking axios
  • introduced utility library for zod fixtures

Main idea behind testing:

Atm I see two cases for testing redux store and the logic inside

  • testing async calls and thunks to make sure that validation of the data is there
  • testing asserting data to the store and manipulating it. Atm it's not complex -> but It will

Pay attention for:

  • missing unit test for rest of the functions Already done
  • utility function for reseting function store should be moved to abstraction Already done
  • store has to be reseted before each test because it's not a mock function -> that's why utility function was created
Edited by Tadeusz Miesiąc

Merge request reports

Merge request pipeline #79162 passed

Stage: lint
    Stage: prettier
      Stage: test

        Merge request pipeline passed for f40b81bf

        Test coverage 81.50% (7.25%) from 1 job

        Merged by Tadeusz MiesiącTadeusz Miesiąc 1 year ago (Oct 4, 2023 11:33am UTC)

        Loading

        Pipeline #79163 failed

        Stage: lint
          Stage: prettier
            Stage: test
              Stage: deploy

                Pipeline failed for bcdd750b on development

                Test coverage 81.50% (7.25%) from 1 job

                Activity

                Filter activity
                • Approvals
                • Assignees & reviewers
                • Comments (from bots)
                • Comments (from users)
                • Commits & branches
                • Edits
                • Labels
                • Lock status
                • Mentions
                • Merge request status
                • Tracking
              • mateuszmiko resolved all threads

                resolved all threads

              • mateuszmiko mentioned in merge request !22 (merged)

                mentioned in merge request !22 (merged)

              • Adrian Orłów
              • Adrian Orłów
                Adrian Orłów @AdrianOrlow started a thread on the diff
                • src/constants/mapId.ts 0 → 100644
                1 export const PROJECT_ID = 'pd_map_winter_23';
              • Adrian Orłów
                Adrian Orłów @AdrianOrlow started a thread on an old version of the diff
                • src/models/referenceSchema.ts 0 → 100644
                1 import { z } from 'zod';
                2
                3 export const referenceSchema = z.object({
                4 link: z.string(),
                5 article: z
              • Adrian Orłów
              • Adrian Orłów
                Adrian Orłów @AdrianOrlow started a thread on the diff
                • src/redux/drugs/drugs.reducers.ts 0 → 100644
                1 import { ActionReducerMapBuilder } from '@reduxjs/toolkit';
                2 import { DrugsState } from './drugs.types';
                3 import { getDrugs } from './drugs.thunks';
                4
                5 export const getDrugsReducer = (builder: ActionReducerMapBuilder<DrugsState>): void => {
                6 builder.addCase(getDrugs.pending, state => {
                7 state.loading = 'pending';
                8 });
                9 builder.addCase(getDrugs.fulfilled, (state, action) => {
                10 state.data = action.payload;
                11 state.loading = 'succeeded';
                12 });
                13 builder.addCase(getDrugs.rejected, state => {
                14 state.loading = 'failed';
                15 // TODO to discuss manage state of failure
              • Adrian Orłów
              • Adrian Orłów
                Adrian Orłów @AdrianOrlow ·
                Developer

                LGTM but there's place for improvements

              • Loading
              • Loading
              • Loading
              • Loading
              • Loading
              • Loading
              • Loading
              • Loading
              • Loading
              • Loading
                • Please register or sign in to reply