Skip to content
Snippets Groups Projects

feat(drawer): add drawer functionality to store

Merged mateuszmiko requested to merge feature/add_drawer_functionality_to_store into development

Objective:

Add drawer functionality to store.

What has been done:

  • Added drawer reducers, selectors, slice and types files in redux folder
  • Added openDrawer function to buttons in NavBar
  • Added closeDrawer function to close button in the Drawer component
  • Added selector to Drawer component
  • tests for reducer
  • first tests for Drawer component
  • added root selector
  • added util function called renderComponentWithProvider for tests
  • added src/utils/*.{ts,tsx} in devDependencies for import/no-extraneous-dependencies

Additionally:

  • added shadow and changed bg color in the map nav bar
  • added example button in the map nav bar
  • added shadow map-navigation-bar to tailwind.config.ts file
Edited by mateuszmiko

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Looks ok. I would fix eslint rule before merging. It's messing code a bit

  • mateuszmiko added 1 commit

    added 1 commit

    • 2d4976d9 - fix(drawer): change source to pathName, delete eslint-disabled comments, add memoized selector

    Compare with previous version

  • mateuszmiko added 2 commits

    added 2 commits

    • 74a3d71a - test(drawer): add first tests to drawer
    • 56f5edab - style(NavBar and TopBar): add shadows, example button, change backgorund color of TopBar

    Compare with previous version

  • mateuszmiko changed the description

    changed the description

  • mateuszmiko resolved all threads

    resolved all threads

  • Adrian Orłów
  • Overall LGTM

  • Adrian Orłów approved this merge request

    approved this merge request

  • mateuszmiko resolved all threads

    resolved all threads

  • mateuszmiko added 1 commit

    added 1 commit

    • 0cde5f12 - fix(drawer): extract the constants for the drawer, extract pathName to types folder

    Compare with previous version

  • mateuszmiko added 3 commits

    added 3 commits

    Compare with previous version

  • mateuszmiko enabled an automatic merge when the pipeline for c18c9383 succeeds

    enabled an automatic merge when the pipeline for c18c9383 succeeds

  • mateuszmiko mentioned in commit 63598af4

    mentioned in commit 63598af4

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading