Skip to content
Snippets Groups Projects

feat: add multisearch (MIN-210)

Merged Adrian Orłów requested to merge MIN-210-multisearch-should-display-all-pins into development
All threads resolved!

Closes MIN-210

Objective

Implement showing all pins but with rendering inactive as semi-transparent blue pins

What has been done:

  • rendering inactive pins with special style
  • selecting tab on inactive pin click
  • new color for chemicals pins
  • unit tests

Additional changes:

I've added opening search drawer on search input click which makes multisearch really useful because it was impossible to make use of tabs when it wasn't possible to open them again after clicking on pin

image image

Edited by Adrian Orłów

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • LGTM, really nice solution. For me clicking on the search input and opening the empty search drawer when we haven't searched anything is strange and I would consider it as an RFC

  • mateusz-winiarczyk approved this merge request

    approved this merge request

  • Adrian Orłów mentioned in merge request !165 (merged)

    mentioned in merge request !165 (merged)

  • Adrian Orłów resolved all threads

    resolved all threads

  • Adrian Orłów added 6 commits

    added 6 commits

    Compare with previous version

  • Adrian Orłów enabled an automatic merge when the pipeline for 06d92953 succeeds

    enabled an automatic merge when the pipeline for 06d92953 succeeds

  • Adrian Orłów canceled the automatic merge

    canceled the automatic merge

  • merged

  • Adrian Orłów mentioned in commit 4a209e78

    mentioned in commit 4a209e78

  • Please register or sign in to reply
    Loading