Skip to content
Snippets Groups Projects

feat: publications modal elements links + reaction search (MIN-241, MIN-229)

Merged feat: publications modal elements links + reaction search (MIN-241, MIN-229)
MIN-241-publications-list-modal-elements-links into development
All threads resolved!
Merged Adrian Orłów requested to merge MIN-241-publications-list-modal-elements-links into development
All threads resolved!

Closes MIN-241, MIN-229

Objective:

Make publications modal elements links interactive along with possibility to search reactions

What has been done:

  • publications modal elements link fetching (target id -> element)
  • possibility to click and search element + auto opening of submap
  • possibility to search for reactions with use of elementId field + auto opening submap
  • reactions loading side effect for bioentity-reactions (reactions in bioentity/content results) along with fetching of reaction's related bioentities
  • resetting search data where needed
  • unit tests

image

image

image

Edited by Adrian Orłów

Merge request reports

Merge request pipeline #88053 passed

Stage: lint
    Stage: prettier
      Stage: test

        Merge request pipeline passed for f4ac4f9e

        Test coverage 91.08% (0.03%) from 1 job
        Approval is optional

        Merged by Adrian OrłówAdrian Orłów 11 months ago (Mar 27, 2024 6:57pm UTC)

        Merge details

        Pipeline #88060 passed

        Stage: lint
          Stage: prettier
            Stage: test
              Stage: deploy

                Pipeline passed for 820e7160 on development

                Test coverage 91.09% (0.03%) from 1 job

                Activity

                Filter activity
                • Approvals
                • Assignees & reviewers
                • Comments (from bots)
                • Comments (from users)
                • Commits & branches
                • Edits
                • Labels
                • Lock status
                • Mentions
                • Merge request status
                • Tracking
              • mateusz-winiarczyk
              • mateusz-winiarczyk
                mateusz-winiarczyk @mateusz-winiarczyk ·
                Developer

                Please resolve conflicts from develop, because there have been a lot of changes that may affect this functionality

                LGTM, the search functionality has become much more complicated with subsequent side effects.

                One question, after click on element from publication list shouldn't it zoom to this element like in the old minerva?

                center-publications-list

              • mateusz-winiarczyk approved this merge request

                approved this merge request

              • Adrian Orłów
                Adrian Orłów @AdrianOrlow ·
                Author Developer

                @mateusz-winiarczyk Regarding element zoom - it's not possible due to high amount of async changes happening in the background

              • Adrian Orłów resolved all threads

                resolved all threads

              • Adrian Orłów added 1 commit

                added 1 commit

                Compare with previous version

              • Adrian Orłów added 25 commits

                added 25 commits

                Compare with previous version

              • Adrian Orłów merged

                merged

              • Adrian Orłów mentioned in commit 820e7160

                mentioned in commit 820e7160

                • Please register or sign in to reply