scheduling-system issueshttps://git-r3lab.uni.lu/smasch/scheduling-system/-/issues2023-10-27T10:02:23+02:00https://git-r3lab.uni.lu/smasch/scheduling-system/-/issues/531Do we need pdfmake JS dependency?2023-10-27T10:02:23+02:00Carlos VegaDo we need pdfmake JS dependency?I see warning on npm audit but I can't find where this package is used other than in smasch/web/templates/subjects/index.html where it is loaded but I believe it is not used.I see warning on npm audit but I can't find where this package is used other than in smasch/web/templates/subjects/index.html where it is loaded but I believe it is not used.https://git-r3lab.uni.lu/smasch/scheduling-system/-/issues/530Replace django-excel with an alternative maintained package, django-import-ex...2023-10-27T09:09:44+02:00Carlos VegaReplace django-excel with an alternative maintained package, django-import-export2023-12-01https://git-r3lab.uni.lu/smasch/scheduling-system/-/issues/529Upgrade to Django 42023-10-27T09:09:57+02:00Carlos VegaUpgrade to Django 4Django 3.2 LTS will end its support in December 7th 2023.
https://www.djangoproject.com/download/
The current limitations for upgrading include:
- Potential breaking changes between versions (to be checked)
- Replace django-excel with...Django 3.2 LTS will end its support in December 7th 2023.
https://www.djangoproject.com/download/
The current limitations for upgrading include:
- Potential breaking changes between versions (to be checked)
- Replace django-excel with an alternative maintained package, `django-import-export` e.g., https://django-import-export.readthedocs.io/en/stable/ , see #5302023-12-07https://git-r3lab.uni.lu/smasch/scheduling-system/-/issues/528CVE-2023-31047: Potential bypass of validation when uploading multiple files ...2023-10-24T10:30:39+02:00Carlos VegaCVE-2023-31047: Potential bypass of validation when uploading multiple files using one form fieldDjango changed the behaviour of fileinput to avoid the vulnerability. However, I don't know how to then create a widget for multiple files.
https://www.djangoproject.com/weblog/2023/may/03/security-releases/
See comments below for furt...Django changed the behaviour of fileinput to avoid the vulnerability. However, I don't know how to then create a widget for multiple files.
https://www.djangoproject.com/weblog/2023/may/03/security-releases/
See comments below for further information.
Relevant links:
https://github.com/advisories/GHSA-r3xc-prgr-mg9p
https://docs.djangoproject.com/en/3.2/topics/http/file-uploads/https://git-r3lab.uni.lu/smasch/scheduling-system/-/issues/526Loss to follow up and next visits2023-10-04T11:32:19+02:00Valentin GrouesLoss to follow up and next visitsI received the following request from Linda (NCER-PD).
> Dear Valentin,
>
> I hope you doing well!
>
> I saw that the patients on "Loss to Follow-Up" still appear in the upcoming appointments. Would it be possible to change that the p...I received the following request from Linda (NCER-PD).
> Dear Valentin,
>
> I hope you doing well!
>
> I saw that the patients on "Loss to Follow-Up" still appear in the upcoming appointments. Would it be possible to change that the participants/patients "Loss to Follow-Up" don't reappear in the "upcoming visits" section?
>
> Thank you and kind Regards
> Lindahttps://git-r3lab.uni.lu/smasch/scheduling-system/-/issues/525make csv export faster2023-10-02T13:35:53+02:00Valentin Grouesmake csv export fasterthe CSV export of subjects available at /study/1export/csv/subjects can become very slow.
for orchestra, with 1471 subjects (also two custom fields), the request can take up to 2 minutes.
check for instance if maybe too many sql request...the CSV export of subjects available at /study/1export/csv/subjects can become very slow.
for orchestra, with 1471 subjects (also two custom fields), the request can take up to 2 minutes.
check for instance if maybe too many sql requests are done.https://git-r3lab.uni.lu/smasch/scheduling-system/-/issues/524add webauthn (.e.g yubikey) support for 2fa2023-07-10T15:27:57+02:00Valentin Grouesadd webauthn (.e.g yubikey) support for 2fahttps://git-r3lab.uni.lu/smasch/scheduling-system/-/issues/523add provenance tracking option to custom subject study fields2024-03-14T15:58:20+01:00Valentin Grouesadd provenance tracking option to custom subject study fieldsthis is a request coming from smasch orchestra. They need provenance information on two custom fields, consent and consent changes.
We could add an option when creation / editing custom fields, asking if changes should be tracked.
We the...this is a request coming from smasch orchestra. They need provenance information on two custom fields, consent and consent changes.
We could add an option when creation / editing custom fields, asking if changes should be tracked.
We then need to create a provenance entry every time changes to those fields are performed.Nirmeen SallamNirmeen Sallamhttps://git-r3lab.uni.lu/smasch/scheduling-system/-/issues/522A way to frame the day of the month in the agenda of Smasch2023-04-04T11:30:42+02:00Carlos VegaA way to frame the day of the month in the agenda of Smasch
> I have a request that is not urgent.
> I wanted to know if there is a way to frame the day of the month in the agenda of Smasch. The background of the day of the month is always a little different but not very conspicuous (for me, I'm...
> I have a request that is not urgent.
> I wanted to know if there is a way to frame the day of the month in the agenda of Smasch. The background of the day of the month is always a little different but not very conspicuous (for me, I'm also old 😀). Maybe we can use it for every Smasch (pd, rbd, pdp, heba).Carlos VegaCarlos Vegahttps://git-r3lab.uni.lu/smasch/scheduling-system/-/issues/518Error when sorting screening number2023-01-12T13:31:21+01:00Carlos VegaError when sorting screening numberIt happens in PRC.
```
'<' not supported between instances of 'str' and 'int'
Traceback (most recent call last):
File "/usr/lib/smasch/web/api_views/subject.py", line 444, in subjects
ordered_subjects = get_subjects_order(filtered...It happens in PRC.
```
'<' not supported between instances of 'str' and 'int'
Traceback (most recent call last):
File "/usr/lib/smasch/web/api_views/subject.py", line 444, in subjects
ordered_subjects = get_subjects_order(filtered_subjects, order_column, order_dir, column_filters=dict(filters))
File "/usr/lib/smasch/web/api_views/subject.py", line 213, in get_subjects_order
reverse=order_direction == '-')
TypeError: '<' not supported between instances of 'str' and 'int'
ERROR 2022-10-10 07:18:46,530 view_utils 32131 140146275432256 When handling POST request for url '/api/subjects/GENERIC' exception occurred
Traceback (most recent call last):
File "/usr/lib/smasch/web/api_views/subject.py", line 444, in subjects
ordered_subjects = get_subjects_order(filtered_subjects, order_column, order_dir, column_filters=dict(filters))
File "/usr/lib/smasch/web/api_views/subject.py", line 213, in get_subjects_order
reverse=order_direction == '-')
TypeError: '<' not supported between instances of 'str' and 'int'
ERROR 2022-10-10 07:18:46,532 log 32131 140146275432256 Internal Server Error: /api/subjects/GENERIC
```Carlos VegaCarlos Vegahttps://git-r3lab.uni.lu/smasch/scheduling-system/-/issues/515Error when exporting template if a field is not available.2023-01-10T11:29:39+01:00Carlos VegaError when exporting template if a field is not available.```
ERROR 2022-08-22 14:11:22,413 view_utils 19748 140146275432256 When handling GET request for url '/mail_templates/5/generate/40053' exception occurred
Traceback (most recent call last):
File "/usr/lib/smasch/env/lib/python3.6/site-...```
ERROR 2022-08-22 14:11:22,413 view_utils 19748 140146275432256 When handling GET request for url '/mail_templates/5/generate/40053' exception occurred
Traceback (most recent call last):
File "/usr/lib/smasch/env/lib/python3.6/site-packages/django/core/handlers/exception.py", line 47, in inner
response = get_response(request)
File "/usr/lib/smasch/env/lib/python3.6/site-packages/django/core/handlers/base.py", line 179, in _get_response
response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/usr/lib/smasch/web/views/mails.py", line 114, in generate
stream = mail_template.apply(instance, request.user, stream)
File "/usr/lib/smasch/web/models/mail_template.py", line 215, in apply
process_file(self.template_file.path, stream, replacements)
File "/usr/lib/smasch/web/docx_helper.py", line 25, in process_file
paragraph.text = paragraph.text.replace(placeholder, replacement)
TypeError: replace() argument 2 must be str, not None
```Carlos VegaCarlos Vega2023-01-18https://git-r3lab.uni.lu/smasch/scheduling-system/-/issues/514ETL export subject - column country is exported as number not string2022-06-17T08:44:00+02:00Ewa SmulaETL export subject - column country is exported as number not stringI don't know if it is a bug, but in export subject - the `column country` is exported as number not string.I don't know if it is a bug, but in export subject - the `column country` is exported as number not string.1.2.1Piotr GawronPiotr Gawronhttps://git-r3lab.uni.lu/smasch/scheduling-system/-/issues/509megre migrations for version 1.12022-06-17T08:42:52+02:00Piotr Gawronmegre migrations for version 1.1https://git-r3lab.uni.lu/smasch/scheduling-system/-/issues/508allow to send mail to user with data (mail template)2022-06-03T14:36:41+02:00Piotr Gawronallow to send mail to user with data (mail template)* send with 2FA (password over SMS)
* allow for bulk sends (send to all)
* sending should be asynchronous - don't send every email/sms at once - antispam filter would block it
* info about all sent emails (with password, link) should be ...* send with 2FA (password over SMS)
* allow for bulk sends (send to all)
* sending should be asynchronous - don't send every email/sms at once - antispam filter would block it
* info about all sent emails (with password, link) should be available in subject
* email text should be configurable
* sms text should be configurablehttps://git-r3lab.uni.lu/smasch/scheduling-system/-/issues/505what is printed when 'print voucher'? how voucher with assigned language beha...2022-03-25T08:45:04+01:00Ewa Smulawhat is printed when 'print voucher'? how voucher with assigned language behaves?1. What document is printed when click on 'print voucher'? I thought it should be voucher-mail-template but now I realised there is no link between voucher-type and mail -template (or I simply cannot find it).
2. for now only multilingu...1. What document is printed when click on 'print voucher'? I thought it should be voucher-mail-template but now I realised there is no link between voucher-type and mail -template (or I simply cannot find it).
2. for now only multilingual mail templated are available in "edit voucher'. In below case there is patient who has _Default language for document generation_ French and _Known languages_ = French. There is mail template for voucher in French. My question is: should the French template be available (image below) or only _multilingual_ are available?
![Screenshot_2022-03-24_at_16.25.03](/uploads/756dda4417601d978a5104725f1d1e23/Screenshot_2022-03-24_at_16.25.03.png)https://git-r3lab.uni.lu/smasch/scheduling-system/-/issues/493(suggestion) remove dot from the privacy notices table2022-01-24T12:43:25+01:00Ewa Smula(suggestion) remove dot from the privacy notices tableAs for now we have only one Study per SMASCH instance. Is the list in column `Studies` set in case there are more than one study per SMASCH instance in the future? I mean the dot/list doesn't look nice there :)
![Screenshot_2022-01-24_...As for now we have only one Study per SMASCH instance. Is the list in column `Studies` set in case there are more than one study per SMASCH instance in the future? I mean the dot/list doesn't look nice there :)
![Screenshot_2022-01-24_at_12.24.05](/uploads/2b66fe40d4a1e088642e209188552988/Screenshot_2022-01-24_at_12.24.05.png)
suggestion:
![Screenshot_2022-01-24_at_12.41.55](/uploads/5b73d1b2354ebb2f3cc9e7b589d9309e/Screenshot_2022-01-24_at_12.41.55.png)https://git-r3lab.uni.lu/smasch/scheduling-system/-/issues/492When Worker is disabled exclude Worker from dropdown list of Worker conductin...2022-01-24T11:46:02+01:00Ewa SmulaWhen Worker is disabled exclude Worker from dropdown list of Worker conducting the assessment in add appointmentWhen Worker is disabled exclude that Worker from dropdown list of `Worker conducting the assessment` in add appointment.When Worker is disabled exclude that Worker from dropdown list of `Worker conducting the assessment` in add appointment.https://git-r3lab.uni.lu/smasch/scheduling-system/-/issues/485add warning dialog before disabled Worker2022-01-19T08:37:45+01:00Ewa Smulaadd warning dialog before disabled Workerfeature to avoid disabling worker by accident.feature to avoid disabling worker by accident.https://git-r3lab.uni.lu/smasch/scheduling-system/-/issues/484sometimes user logs in without providing token2022-01-18T10:27:59+01:00Ewa Smulasometimes user logs in without providing tokenI am not sure if it is a bug, but sometimes user can log in to SMASCH without providing token. Token is sent, but the logging is successful without providing token. Issue occurs for a user who is disabled and enabled again, but it can be...I am not sure if it is a bug, but sometimes user can log in to SMASCH without providing token. Token is sent, but the logging is successful without providing token. Issue occurs for a user who is disabled and enabled again, but it can be related to refresh of windows in the browser. I had two private windows with SMASCH open - in one window "user-admin" was logged in and he disabled and then enabled "user". In the second SMASCH window "user" tried to logged in.https://git-r3lab.uni.lu/smasch/scheduling-system/-/issues/483Move logic from MailTemplate model into view2021-10-20T10:14:07+02:00Piotr GawronMove logic from MailTemplate model into view