From f93773a271c705ded350fd51369dc74dbbebf91d Mon Sep 17 00:00:00 2001
From: Piotr Gawron <piotr.gawron@uni.lu>
Date: Tue, 16 Mar 2021 14:12:56 +0100
Subject: [PATCH] filtering should be done via id

---
 smash/web/api_views/subject.py            | 2 +-
 smash/web/tests/api_views/test_subject.py | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/smash/web/api_views/subject.py b/smash/web/api_views/subject.py
index f5c777cc..2a817787 100644
--- a/smash/web/api_views/subject.py
+++ b/smash/web/api_views/subject.py
@@ -373,7 +373,7 @@ def get_subjects_filtered(subjects_to_be_filtered: QuerySet, filters) -> QuerySe
         elif column == "flying_team":
             result = result.filter(flying_team=value)
         elif column == "type":
-            result = result.filter(type__name=value)
+            result = result.filter(type_id=value)
         elif str(column).startswith("visit_"):
             visit_number = get_visit_number_from_visit_x_string(column)
             result = filter_by_visit(result, visit_number, value)
diff --git a/smash/web/tests/api_views/test_subject.py b/smash/web/tests/api_views/test_subject.py
index 97943bb1..1d6a915a 100644
--- a/smash/web/tests/api_views/test_subject.py
+++ b/smash/web/tests/api_views/test_subject.py
@@ -448,8 +448,8 @@ class TestSubjectApi(LoggedInWithWorkerTestCase):
         subject.type = get_patient_subject_type()
         subject.save()
 
-        self.check_subject_filtered([["type", get_patient_subject_type().name]], [subject])
-        self.check_subject_filtered([["type", get_control_subject_type().name]], [])
+        self.check_subject_filtered([["type", get_patient_subject_type().id]], [subject])
+        self.check_subject_filtered([["type", get_control_subject_type().id]], [])
 
     def test_subjects_filter_unknown(self):
         subject = self.study_subject
-- 
GitLab