diff --git a/CHANGELOG b/CHANGELOG index 95d304a9c3ac5ec7720fa4b4e6eece8368790f7b..6d617bcff8160deb52c349d224009798e89ec071 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -16,8 +16,11 @@ minerva (14.0.5) stable; urgency=medium #1012) * Bug fix: after loading/removing too many plugins it was impossible to load new plugins (#1011) + * Bug fix: CLEAR button disappears after legend, comment checkboxes when + plugin tab used to much space (#976) - -- Piotr Gawron Mon, 02 Dec 2019 16:00:00 +0200 + + -- Piotr Gawron Tue, 03 Dec 2019 12:00:00 +0200 minerva (14.0.4) stable; urgency=high * Bug fix: some SBGN files uploaded to minerva could not be exported to SBML diff --git a/frontend-js/src/main/css/global.css b/frontend-js/src/main/css/global.css index 85376e0f31d089beb1dd38c028804ee90f1d71d1..cdfb749a06ccc5eb293be93f96dcd96d57a70355 100644 --- a/frontend-js/src/main/css/global.css +++ b/frontend-js/src/main/css/global.css @@ -57,9 +57,7 @@ h5 { color: #ffffff; display: inline; width: auto; - position: absolute; - top: 0; - right: 0; + float: right; } .minerva-header a:hover { diff --git a/frontend-js/src/main/js/ServerConnector.js b/frontend-js/src/main/js/ServerConnector.js index 1b12de302ae132964e2af3891b85d1bef918a410..d8f03818b15bccc1475a74b09963a158b9ae71e5 100644 --- a/frontend-js/src/main/js/ServerConnector.js +++ b/frontend-js/src/main/js/ServerConnector.js @@ -1340,6 +1340,10 @@ ServerConnector.getLoggedUser = function () { if (self._loggedUser !== undefined && self._loggedUser !== null) { return Promise.resolve(self._loggedUser); } else { + if (self.getSessionData().getLogin() === null) { + logger.warn("User login is null..."); + window.location.reload(false); + } //this prevents double calls self._loggedUser = self.getUser(self.getSessionData().getLogin()).then(function (user) { if (user !== null) { @@ -2049,7 +2053,7 @@ ServerConnector.createSession = function () { ServerConnector.login = function (login, password) { var self = this; var params = {}; - if (login !== undefined && login !== "") { + if (login !== undefined && login !== "" && login !== null) { params.login = login; params.password = password; } else { diff --git a/frontend-js/src/main/js/gui/topMenu/TopMenu.js b/frontend-js/src/main/js/gui/topMenu/TopMenu.js index 08ba1e70d3a525c94a9e3b9e882beb39bf4f4b00..23969f0dac6161074715e01789a79232cb579301 100644 --- a/frontend-js/src/main/js/gui/topMenu/TopMenu.js +++ b/frontend-js/src/main/js/gui/topMenu/TopMenu.js @@ -102,17 +102,22 @@ TopMenu.prototype._createGui = function () { showOverviewDiv.appendChild(showOverviewButton); self.setControlElement(PanelControlElementType.MENU_SHOW_OVERVIEW_BUTTON, showOverviewButton); - var rightHeaderMenuDiv = Functions.createElement({ - type: "div", - className: "minerva-header-right-menu" + var clearButton = Functions.createElement({ + type: "button", + name: "clearButton", + className: "minerva-overview-button", + style: "float:right", + content: "CLEAR", + xss: false }); - self.getElement().appendChild(rightHeaderMenuDiv); + self.getElement().appendChild(clearButton); var div4checkboxes = Functions.createElement({ type: "div", + style: "float:right", className: "minerva-top-checkbox-div" }); - rightHeaderMenuDiv.appendChild(div4checkboxes); + self.getElement().appendChild(div4checkboxes); var legendCheckbox = Functions.createElement({ type: "input", @@ -149,14 +154,6 @@ TopMenu.prototype._createGui = function () { div4checkboxes.appendChild(refreshCommentButton); self.setControlElement(PanelControlElementType.MENU_REFRESH_COMMENTS_BUTTON, refreshCommentButton); - var clearButton = Functions.createElement({ - type: "button", - name: "clearButton", - className: "minerva-overview-button", - content: "CLEAR", - xss: false - }); - rightHeaderMenuDiv.appendChild(clearButton); self.setControlElement(PanelControlElementType.MENU_CLEAR_BUTTON, clearButton); };