From f7cc264cd6e1adfbc10d3ebf58e8d963153ed316 Mon Sep 17 00:00:00 2001
From: Piotr Gawron <piotr.gawron@uni.lu>
Date: Fri, 4 May 2018 09:40:08 +0200
Subject: [PATCH] fix on warnings due to type mismatch
---
frontend-js/src/main/js/gui/AddOverlayDialog.js | 5 +++++
.../src/main/js/gui/leftPanel/OverlayPanel.js | 14 ++++++++++----
2 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/frontend-js/src/main/js/gui/AddOverlayDialog.js b/frontend-js/src/main/js/gui/AddOverlayDialog.js
index 2e4cd33aa1..8d730471ae 100644
--- a/frontend-js/src/main/js/gui/AddOverlayDialog.js
+++ b/frontend-js/src/main/js/gui/AddOverlayDialog.js
@@ -179,8 +179,13 @@ AddOverlayDialog.prototype.addOverlay = function () {
});
};
+/**
+ *
+ * @returns {PromiseLike}
+ */
AddOverlayDialog.prototype.destroy = function () {
$(this.getElement()).dialog("destroy");
+ return Promise.resolve();
};
AddOverlayDialog.prototype.open = function () {
diff --git a/frontend-js/src/main/js/gui/leftPanel/OverlayPanel.js b/frontend-js/src/main/js/gui/leftPanel/OverlayPanel.js
index 7ccaf090ba..f9e95e7d3c 100644
--- a/frontend-js/src/main/js/gui/leftPanel/OverlayPanel.js
+++ b/frontend-js/src/main/js/gui/leftPanel/OverlayPanel.js
@@ -173,10 +173,13 @@ OverlayPanel.prototype.clear = function () {
/**
*
- * @param {boolean} edit
+ * @param {boolean} [edit=false]
* @returns {HTMLElement}
*/
OverlayPanel.prototype.createTableHeader = function (edit) {
+ if (edit === undefined) {
+ edit = false;
+ }
var result = document.createElement("thead");
var row = document.createElement("tr");
@@ -363,10 +366,13 @@ OverlayPanel.prototype.openEditOverlayDialog = function (overlay) {
/**
*
- * @param {boolean} showDefault
+ * @param {boolean} [showDefault=false]
* @returns {PromiseLike}
*/
OverlayPanel.prototype.refresh = function (showDefault) {
+ if (showDefault === undefined) {
+ showDefault = false;
+ }
var self = this;
var user = null;
@@ -439,7 +445,7 @@ OverlayPanel.prototype.refresh = function (showDefault) {
title.innerHTML = self.getCustomOverlaysMessage();
addButton.style.display = "block";
- table = $(tableElement).on('order.dt', function (e) {
+ table = $(tableElement).on('order.dt', function () {
if ($(tableElement).dataTable().fnSettings().aaSorting[0][0] === 0) {
table.rowReorder.enable();
} else {
@@ -544,7 +550,7 @@ OverlayPanel.prototype.init = function () {
info: false,
rowReorder: true
});
- table.on('row-reorder', function (e, diff, edit) {
+ table.on('row-reorder', function (e, diff) {
var promises = [];
for (var i = 0, ien = diff.length; i < ien; i++) {
--
GitLab