Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Menu
Open sidebar
minerva
core
Commits
dccafab3
Commit
dccafab3
authored
Jun 03, 2020
by
Piotr Gawron
Browse files
Merge branch '1252-hgnc-id' into 'devel_14.0.x'
remove prefix from hgnc symbol See merge request
!1156
parents
58192e5c
b379b2c0
Pipeline
#27532
passed with stage
in 11 minutes and 20 seconds
Changes
3
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
CHANGELOG
View file @
dccafab3
minerva
(
14.0.13
)
stable
;
urgency
=
medium
*
Bug
fix
:
chrome
modified
default
css
and
service
looked
ugly
in
chrome
(#
1260
)
*
Bug
fix
:
uploaded
HGNC
identifiers
that
looks
like
"HGNC:HGNC:1234"
are
changed
to
"HGNC:1234"
(#
1252
)
--
Piotr
Gawron
<
piotr
.
gawron
@
uni
.
lu
>
Wed
,
3
Jun
2020
17
:
00
:
00
+
0200
...
...
model/src/main/java/lcsb/mapviewer/model/map/MiriamData.java
View file @
dccafab3
...
...
@@ -177,6 +177,11 @@ public class MiriamData implements Comparable<MiriamData>, Serializable {
this
.
resource
=
null
;
}
else
{
this
.
resource
=
resource
.
replace
(
"%3A"
,
":"
);
if
(
this
.
dataType
==
MiriamType
.
HGNC
&&
this
.
resource
.
toLowerCase
().
startsWith
(
"hgnc:"
))
{
String
newResource
=
this
.
resource
.
substring
(
5
);
logger
.
debug
(
"hgnc identifier: \""
+
this
.
resource
+
"\" is changed to: \""
+
newResource
+
"\""
);
this
.
resource
=
newResource
;
}
}
}
...
...
model/src/test/java/lcsb/mapviewer/model/map/MiriamDataTest.java
View file @
dccafab3
...
...
@@ -79,4 +79,11 @@ public class MiriamDataTest extends ModelTestFunctions {
md2
.
setAnnotator
(
Integer
.
class
);
assertTrue
(
md1
.
compareTo
(
md2
)
==
0
);
}
@Test
public
void
testHgncIdWithPrefix
()
{
assertEquals
(
new
MiriamData
(
MiriamType
.
HGNC
,
"1234"
),
new
MiriamData
(
MiriamType
.
HGNC
,
"HGNC:1234"
));
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment