diff --git a/CHANGELOG b/CHANGELOG index bcad28693dbb827049498ca7e28f3ce983906ff7..95ab681c27601f927aeb02f91b45b9dcf33e912b 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,4 +1,6 @@ minerva (14.0.3) stable; urgency=medium + * Bug fix: default zoom level on main map works even when x or y are + undefined (#993) * Bug fix: sbml parser had sometimes problems with combining layout and multi packages (#966) * Bug fix: parsing of CellDesigner files that contained substanceUnits could diff --git a/frontend-js/src/main/js/map/CustomMap.js b/frontend-js/src/main/js/map/CustomMap.js index e185ff683a0ee929affd1f9519045b6eb5a7059d..83d5252d75bd8ab27c6b064bec711168c4bcf27d 100644 --- a/frontend-js/src/main/js/map/CustomMap.js +++ b/frontend-js/src/main/js/map/CustomMap.js @@ -105,9 +105,8 @@ CustomMap.prototype.init = function () { var zoom = self.getModel().getDefaultZoomLevel(); var autoFit = false; if (self.getServerConnector().getSessionData(self.getProject()).getCenter(self.getModel()) === undefined && - (x === undefined || y === undefined || zoom === undefined || - x === null || y === null || zoom === null - )) { + (x === undefined || y === undefined || x === null || y === null) && + (zoom === undefined || zoom === null)) { autoFit = true; } diff --git a/frontend-js/src/main/js/map/data/MapModel.js b/frontend-js/src/main/js/map/data/MapModel.js index ed7ff8b9c8e7ddfabd5133ad26f3e458d0333f92..4d19adf52b3d808c2ba2abd668d04514a02a5d12 100644 --- a/frontend-js/src/main/js/map/data/MapModel.js +++ b/frontend-js/src/main/js/map/data/MapModel.js @@ -547,7 +547,7 @@ MapModel.prototype.setMinZoom = function (minZoom) { /** * - * @returns {number|null} + * @returns {?null|number} */ MapModel.prototype.getDefaultZoomLevel = function () { return this._defaultZoomLevel; @@ -567,7 +567,7 @@ MapModel.prototype.setDefaultZoomLevel = function (defaultZoomLevel) { /** * - * @returns {null|number} + * @returns {?null|number} */ MapModel.prototype.getDefaultCenterX = function () { return this._defaultCenterX; @@ -587,7 +587,7 @@ MapModel.prototype.setDefaultCenterX = function (defaultCenterX) { /** * - * @returns {number|null} + * @returns {?null|number} */ MapModel.prototype.getDefaultCenterY = function () { return this._defaultCenterY;