Merge branch '1121-remove-overlay-twice' into 'devel_14.0.x'

don't allow to remove data overlay twice

See merge request !1065

CHANGELOG

@@ -6,6 +6,8 @@ minerva (14.0.9) stable; urgency=medium
   * Bug fix: transparent complexes are shown with wrong color (#1103)
   * Bug fix: CellDesigner sometimes marked reduced notation reaction as
     reversible even though they were not visualized so (#1109)
+  * Bug fix: when data overlay was being removed user could request to remove
+    overlay second time and an error was thrown (#1121)
 
  -- Piotr Gawron <piotr.gawron@uni.lu>  Mon, 3 Feb 2020 15:00:00 +0200
 

frontend-js/src/main/js/gui/leftPanel/OverlayPanel.js

@@ -422,9 +422,12 @@ OverlayPanel.prototype.openEditOverlayDialog = function (overlay) {
         message: "Do you want to delete overlay: " + overlay.getName() + "?"
       }).then(function (confirmation) {
         if (confirmation) {
+          GuiConnector.showProcessing("Removing");
           return self.removeOverlay(overlay).then(function () {
             $(windowSelf).dialog("close");
-          }).catch(GuiConnector.alert);
+          }).catch(GuiConnector.alert).finally(function () {
+            GuiConnector.hideProcessing();
+          });
         }
       });
     }