From c01ba6a425ea377e8e571015fa09ce4d95182e8a Mon Sep 17 00:00:00 2001
From: Piotr Gawron <piotr.gawron@uni.lu>
Date: Wed, 5 Jul 2017 15:24:27 +0200
Subject: [PATCH] lint issues
---
frontend-js/src/main/js/gui/CommentDialog.js | 2 +-
frontend-js/src/main/js/gui/leftPanel/GuiUtils.js | 7 +++----
frontend-js/src/main/js/gui/leftPanel/LeftPanel.js | 3 +--
frontend-js/src/main/js/map/AbstractCustomMap.js | 9 +++------
frontend-js/src/main/js/map/CustomMap.js | 8 ++++----
frontend-js/src/main/js/map/data/BioEntity.js | 2 +-
frontend-js/src/main/js/map/data/IdentifiedElement.js | 2 +-
frontend-js/src/main/js/map/marker/AbstractMarker.js | 2 +-
frontend-js/src/main/js/map/marker/AliasMarker.js | 1 -
frontend-js/src/main/js/map/marker/PointMarker.js | 1 -
frontend-js/src/main/js/map/marker/ReactionMarker.js | 1 -
frontend-js/src/main/js/map/overlay/CommentDbOverlay.js | 2 +-
.../src/main/js/map/surface/AbstractSurfaceElement.js | 2 +-
frontend-js/src/main/js/map/surface/ReactionSurface.js | 2 ++
frontend-js/src/main/js/map/window/AbstractInfoWindow.js | 3 +--
frontend-js/src/main/js/map/window/AliasInfoWindow.js | 1 -
frontend-js/src/main/js/map/window/PointInfoWindow.js | 1 -
frontend-js/src/main/js/map/window/ReactionInfoWindow.js | 1 -
frontend-js/src/test/js/gui/leftPanel/GuiUtils-test.js | 1 -
.../src/test/js/gui/leftPanel/SearchPanel-test.js | 6 +++---
frontend-js/src/test/js/map/Submap-test.js | 2 +-
frontend-js/src/test/js/map/data/MapModel-test.js | 2 +-
frontend-js/src/test/js/map/surface/AliasSurface-test.js | 2 +-
23 files changed, 26 insertions(+), 37 deletions(-)
diff --git a/frontend-js/src/main/js/gui/CommentDialog.js b/frontend-js/src/main/js/gui/CommentDialog.js
index f29bcb3c98..5f4fe6f827 100644
--- a/frontend-js/src/main/js/gui/CommentDialog.js
+++ b/frontend-js/src/main/js/gui/CommentDialog.js
@@ -247,7 +247,7 @@ CommentDialog.prototype.getEmail = function() {
};
CommentDialog.prototype.setEmail = function(email) {
- return this.getEmailInput().value = email;
+ this.getEmailInput().value = email;
};
CommentDialog.prototype.getContent = function() {
diff --git a/frontend-js/src/main/js/gui/leftPanel/GuiUtils.js b/frontend-js/src/main/js/gui/leftPanel/GuiUtils.js
index 3cc02d8e77..50351e7bd0 100644
--- a/frontend-js/src/main/js/gui/leftPanel/GuiUtils.js
+++ b/frontend-js/src/main/js/gui/leftPanel/GuiUtils.js
@@ -4,12 +4,11 @@
var GuiConnector = require('../../GuiConnector');
var AbstractGuiElement = require('../AbstractGuiElement');
-var PanelControlElementType = require('../PanelControlElementType');
var Functions = require('../../Functions');
var logger = require('../../logger');
-function GuiUtils(params) {
+function GuiUtils() {
}
GuiUtils.prototype = Object.create(AbstractGuiElement.prototype);
@@ -274,7 +273,7 @@ GuiUtils.prototype.createReactionElement = function(reaction) {
div.appendChild(self.createCandidates("Candidates: ", reaction.getOther('dataMining')));
div.appendChild(self.createAnnotations("Annotations: ", reaction.getReferences()));
return div;
-}
+};
GuiUtils.prototype.createAliasElement = function(alias, icon) {
var self = this;
@@ -305,7 +304,7 @@ GuiUtils.prototype.createAliasElement = function(alias, icon) {
div.appendChild(self.createChebiTree("Chebi ontology: ", alias.getOther('chebiTree')));
div.appendChild(self.createAnnotations("Annotations: ", alias.getReferences()));
return div;
-}
+};
GuiUtils.prototype.createReactantsLine = function(label, value) {
var result = document.createElement("div");
diff --git a/frontend-js/src/main/js/gui/leftPanel/LeftPanel.js b/frontend-js/src/main/js/gui/leftPanel/LeftPanel.js
index dd1d0eee16..ef79b200ce 100644
--- a/frontend-js/src/main/js/gui/leftPanel/LeftPanel.js
+++ b/frontend-js/src/main/js/gui/leftPanel/LeftPanel.js
@@ -168,7 +168,6 @@ LeftPanel.prototype.showElementDetails = function(element) {
of : $(self.getElement()),
},
}).siblings('.ui-dialog-titlebar').css("background", "gray");
- ;
}
var openTabName = $("[name='tabView'] > ul li.active a")[0].innerHTML;
@@ -188,7 +187,7 @@ LeftPanel.prototype.showElementDetails = function(element) {
$(div).dialog("close");
return Promise.resolve();
}
-}
+};
LeftPanel.prototype.prepareElementDetailsContent = function(bioEntity) {
var guiUtils = new GuiUtils();
diff --git a/frontend-js/src/main/js/map/AbstractCustomMap.js b/frontend-js/src/main/js/map/AbstractCustomMap.js
index e8a6637a53..9fb7383aa8 100644
--- a/frontend-js/src/main/js/map/AbstractCustomMap.js
+++ b/frontend-js/src/main/js/map/AbstractCustomMap.js
@@ -6,15 +6,12 @@ var logger = require('../logger');
var functions = require('../Functions');
var AliasInfoWindow = require('./window/AliasInfoWindow');
-var AliasMarker = require('./marker/AliasMarker');
var AliasSurface = require('./surface/AliasSurface');
var IdentifiedElement = require('./data/IdentifiedElement');
var ObjectWithListeners = require('../ObjectWithListeners');
var PointData = require('./data/PointData');
var PointInfoWindow = require('./window/PointInfoWindow');
-var PointMarker = require('./marker/PointMarker');
var ReactionInfoWindow = require('./window/ReactionInfoWindow');
-var ReactionMarker = require('./marker/ReactionMarker');
var ReactionSurface = require('./surface/ReactionSurface');
/**
@@ -606,7 +603,7 @@ AbstractCustomMap.prototype._showSelectedLayout = function(layoutId, index, leng
startX : startX,
endX : endX,
onClick : [ function() {
- return self._openInfoWindowForIdentifiedElement(element, surface.getGoogleMarker())
+ return self._openInfoWindowForIdentifiedElement(element, surface.getGoogleMarker());
}, function() {
return self.getTopMap().callListeners("onBioEntityClick", element);
} ]
@@ -627,7 +624,7 @@ AbstractCustomMap.prototype._showSelectedLayout = function(layoutId, index, leng
reaction : reactionData,
map : self,
onClick : [ function() {
- return self._openInfoWindowForIdentifiedElement(element, surface.getGoogleMarker())
+ return self._openInfoWindowForIdentifiedElement(element, surface.getGoogleMarker());
}, function() {
return self.getTopMap().callListeners("onBioEntityClick", element);
} ],
@@ -823,7 +820,7 @@ AbstractCustomMap.prototype.returnInfoWindowForIdentifiedElement = function(elem
} else if (element.getType() === "REACTION") {
return this.getReactionInfoWindowById(markerId);
} else {
- throw new Error("Unknown marker type: ", marker);
+ throw new Error("Unknown marker type: ", element);
}
};
diff --git a/frontend-js/src/main/js/map/CustomMap.js b/frontend-js/src/main/js/map/CustomMap.js
index 43dec82621..3ab6794c0f 100644
--- a/frontend-js/src/main/js/map/CustomMap.js
+++ b/frontend-js/src/main/js/map/CustomMap.js
@@ -275,12 +275,12 @@ CustomMap.prototype.registerDbOverlay = function(dbOverlay) {
});
}
if (dbOverlay.getName() === "comment") {
- var listener = function(e) {
+ var listener = function() {
return self.renderOverlayCollection({
overlayCollection : dbOverlay,
fitBounds : false
});
- }
+ };
dbOverlay.addListener("onRefresh", listener);
dbOverlay.addListener("onClear", listener);
}
@@ -1269,7 +1269,7 @@ CustomMap.prototype.createSurfaceForDbOverlay = function(element, dbOverlay) {
element : element,
map : self,
onClick : [ function() {
- return self.openInfoWindowForIdentifiedElement(element, result.getGoogleMarker())
+ return self.openInfoWindowForIdentifiedElement(element, result.getGoogleMarker());
}, function() {
return self.callListeners("onBioEntityClick", element);
} ]
@@ -1286,7 +1286,7 @@ CustomMap.prototype.createSurfaceForDbOverlay = function(element, dbOverlay) {
customized : true,
color : element.getColor(),
onClick : [ function() {
- return self.openInfoWindowForIdentifiedElement(element, result.getGoogleMarker())
+ return self.openInfoWindowForIdentifiedElement(element, result.getGoogleMarker());
}, function() {
return self.callListeners("onBioEntityClick", element);
} ]
diff --git a/frontend-js/src/main/js/map/data/BioEntity.js b/frontend-js/src/main/js/map/data/BioEntity.js
index 149dfd3976..086adedcb8 100644
--- a/frontend-js/src/main/js/map/data/BioEntity.js
+++ b/frontend-js/src/main/js/map/data/BioEntity.js
@@ -6,7 +6,7 @@
* @param javaObject
* object deserialized ajax query to the server side
*/
-function BioEntity(javaObject) {
+function BioEntity() {
}
BioEntity.prototype.getLinkedSubmodelId = function() {
diff --git a/frontend-js/src/main/js/map/data/IdentifiedElement.js b/frontend-js/src/main/js/map/data/IdentifiedElement.js
index a94780790e..caa6ef2d22 100644
--- a/frontend-js/src/main/js/map/data/IdentifiedElement.js
+++ b/frontend-js/src/main/js/map/data/IdentifiedElement.js
@@ -220,6 +220,6 @@ IdentifiedElement.prototype.toString = function() {
var self = this;
return "[" + IdentifiedElement.prototype.constructor.name + "] " + self.getType() + " " + self.getId() + " (model: "
+ self.getModelId() + ")";
-}
+};
module.exports = IdentifiedElement;
diff --git a/frontend-js/src/main/js/map/marker/AbstractMarker.js b/frontend-js/src/main/js/map/marker/AbstractMarker.js
index 2c2093bb43..e8e27bb2ed 100644
--- a/frontend-js/src/main/js/map/marker/AbstractMarker.js
+++ b/frontend-js/src/main/js/map/marker/AbstractMarker.js
@@ -159,7 +159,7 @@ AbstractMarker.prototype._init = function() {
AbstractMarker.prototype.onClickHandler = function() {
return this.callListeners("onClick");
-}
+};
/**
* Returns {google.maps.Marker} connected to this object.
diff --git a/frontend-js/src/main/js/map/marker/AliasMarker.js b/frontend-js/src/main/js/map/marker/AliasMarker.js
index 4a898fe910..26fda035d9 100644
--- a/frontend-js/src/main/js/map/marker/AliasMarker.js
+++ b/frontend-js/src/main/js/map/marker/AliasMarker.js
@@ -1,7 +1,6 @@
"use strict";
var AbstractMarker = require('./AbstractMarker');
-var IdentifiedElement = require('../data/IdentifiedElement');
/**
* This class describes Google maps marker (connected to {@link Alias}) that is
diff --git a/frontend-js/src/main/js/map/marker/PointMarker.js b/frontend-js/src/main/js/map/marker/PointMarker.js
index db1a923d35..80bca73f83 100644
--- a/frontend-js/src/main/js/map/marker/PointMarker.js
+++ b/frontend-js/src/main/js/map/marker/PointMarker.js
@@ -1,7 +1,6 @@
"use strict";
var AbstractMarker = require('./AbstractMarker');
-var IdentifiedElement = require('../data/IdentifiedElement');
var PointData = require('../data/PointData');
/**
diff --git a/frontend-js/src/main/js/map/marker/ReactionMarker.js b/frontend-js/src/main/js/map/marker/ReactionMarker.js
index c51d24af09..10a1b82f7b 100644
--- a/frontend-js/src/main/js/map/marker/ReactionMarker.js
+++ b/frontend-js/src/main/js/map/marker/ReactionMarker.js
@@ -1,7 +1,6 @@
"use strict";
var AbstractMarker = require('./AbstractMarker');
-var IdentifiedElement = require('../data/IdentifiedElement');
/**
* This class describes Google maps marker (connected to {@link Reaction}) that
diff --git a/frontend-js/src/main/js/map/overlay/CommentDbOverlay.js b/frontend-js/src/main/js/map/overlay/CommentDbOverlay.js
index 306938154f..7364c1e1e4 100644
--- a/frontend-js/src/main/js/map/overlay/CommentDbOverlay.js
+++ b/frontend-js/src/main/js/map/overlay/CommentDbOverlay.js
@@ -52,7 +52,7 @@ CommentDbOverlay.prototype.getDetailDataByIdentifiedElement = function(element)
if (this._detailDataByIdentifiedElement[elementKey] !== undefined) {
return Promise.resolve(this._detailDataByIdentifiedElement[elementKey]);
} else {
- var coordinates = undefined;
+ var coordinates;
if (element.getType() === "POINT") {
coordinates = element.getPoint().x + "," + element.getPoint().y;
}
diff --git a/frontend-js/src/main/js/map/surface/AbstractSurfaceElement.js b/frontend-js/src/main/js/map/surface/AbstractSurfaceElement.js
index fb07140b88..4a8d7b2b58 100644
--- a/frontend-js/src/main/js/map/surface/AbstractSurfaceElement.js
+++ b/frontend-js/src/main/js/map/surface/AbstractSurfaceElement.js
@@ -72,7 +72,7 @@ AbstractOverlayElement.prototype.hide = function() {
AbstractOverlayElement.prototype.onClickHandler = function() {
return this.callListeners("onClick");
-}
+};
AbstractOverlayElement.prototype.getGoogleMarker = function() {
return this.getGoogleMapObjects()[0];
diff --git a/frontend-js/src/main/js/map/surface/ReactionSurface.js b/frontend-js/src/main/js/map/surface/ReactionSurface.js
index 557ab143a9..0a4432fdc9 100644
--- a/frontend-js/src/main/js/map/surface/ReactionSurface.js
+++ b/frontend-js/src/main/js/map/surface/ReactionSurface.js
@@ -1,5 +1,7 @@
"use strict";
+/* exported logger */
+
var functions = require('../../Functions');
var logger = require('../../logger');
diff --git a/frontend-js/src/main/js/map/window/AbstractInfoWindow.js b/frontend-js/src/main/js/map/window/AbstractInfoWindow.js
index 17fb257667..8212bbf489 100644
--- a/frontend-js/src/main/js/map/window/AbstractInfoWindow.js
+++ b/frontend-js/src/main/js/map/window/AbstractInfoWindow.js
@@ -4,7 +4,6 @@ var logger = require('../../logger');
var Comment = require('../data/Comment');
var IdentifiedElement = require('../data/IdentifiedElement');
-var AbstractMarker = require('../marker/AbstractMarker');
var ObjectWithListeners = require('../../ObjectWithListeners');
/**
@@ -307,7 +306,7 @@ AbstractInfoWindow.prototype.getGoogleMarker = function() {
};
AbstractInfoWindow.prototype.setGoogleMarker = function(marker) {
- return this._marker = marker;
+ this._marker = marker;
};
/**
diff --git a/frontend-js/src/main/js/map/window/AliasInfoWindow.js b/frontend-js/src/main/js/map/window/AliasInfoWindow.js
index 0057a7b30f..1bf6e6c195 100644
--- a/frontend-js/src/main/js/map/window/AliasInfoWindow.js
+++ b/frontend-js/src/main/js/map/window/AliasInfoWindow.js
@@ -4,7 +4,6 @@ var logger = require('../../logger');
var functions = require('../../Functions');
var AbstractInfoWindow = require('./AbstractInfoWindow');
-var AliasMarker = require('../marker/AliasMarker');
var Alias = require('../data/Alias');
var LayoutAlias = require('../data/LayoutAlias');
var pileup = require('pileup');
diff --git a/frontend-js/src/main/js/map/window/PointInfoWindow.js b/frontend-js/src/main/js/map/window/PointInfoWindow.js
index 163ce6526b..7a32e32dd2 100644
--- a/frontend-js/src/main/js/map/window/PointInfoWindow.js
+++ b/frontend-js/src/main/js/map/window/PointInfoWindow.js
@@ -3,7 +3,6 @@
var Promise = require("bluebird");
var AbstractInfoWindow = require('./AbstractInfoWindow');
-var PointMarker = require('../marker/PointMarker');
function PointInfoWindow(params) {
// call super constructor
diff --git a/frontend-js/src/main/js/map/window/ReactionInfoWindow.js b/frontend-js/src/main/js/map/window/ReactionInfoWindow.js
index 7b59666e6b..a3f7a33f28 100644
--- a/frontend-js/src/main/js/map/window/ReactionInfoWindow.js
+++ b/frontend-js/src/main/js/map/window/ReactionInfoWindow.js
@@ -4,7 +4,6 @@ var Promise = require("bluebird");
var AbstractInfoWindow = require('./AbstractInfoWindow');
var Reaction = require('../data/Reaction');
-var ReactionMarker = require('../marker/ReactionMarker');
/**
* Class representing info window that should be opened when clicking on
diff --git a/frontend-js/src/test/js/gui/leftPanel/GuiUtils-test.js b/frontend-js/src/test/js/gui/leftPanel/GuiUtils-test.js
index 74334f01b9..7b30070888 100644
--- a/frontend-js/src/test/js/gui/leftPanel/GuiUtils-test.js
+++ b/frontend-js/src/test/js/gui/leftPanel/GuiUtils-test.js
@@ -6,7 +6,6 @@ require('../../mocha-config.js');
var Alias = require('../../../../main/js/map/data/Alias');
var GuiUtils = require('../../../../main/js/gui/leftPanel/GuiUtils');
-var PanelControlElementType = require('../../../../main/js/gui/PanelControlElementType');
var chai = require('chai');
var assert = chai.assert;
diff --git a/frontend-js/src/test/js/gui/leftPanel/SearchPanel-test.js b/frontend-js/src/test/js/gui/leftPanel/SearchPanel-test.js
index 402df98a18..e78045cefb 100644
--- a/frontend-js/src/test/js/gui/leftPanel/SearchPanel-test.js
+++ b/frontend-js/src/test/js/gui/leftPanel/SearchPanel-test.js
@@ -177,14 +177,14 @@ describe('SearchPanel', function() {
var map = helper.createCustomMap();
helper.createSearchDbOverlay(map);
- var panel = new SearchPanel({
+ new SearchPanel({
element : testDiv,
customMap : map
});
$(".typeahead", testDiv)[0].value = "some input";
- return map.clearDbOverlays().then(function (){
- assert.equal("",$(":input", testDiv)[0].value);
+ return map.clearDbOverlays().then(function() {
+ assert.equal("", $(":input", testDiv)[0].value);
});
});
});
diff --git a/frontend-js/src/test/js/map/Submap-test.js b/frontend-js/src/test/js/map/Submap-test.js
index c9af0b432b..67e4cef970 100644
--- a/frontend-js/src/test/js/map/Submap-test.js
+++ b/frontend-js/src/test/js/map/Submap-test.js
@@ -72,7 +72,7 @@ describe('Submap', function() {
map : submap
});
return marker.init();
- }).then(function(alias) {
+ }).then(function() {
assert.ok(marker.getAliasData());
});
});
diff --git a/frontend-js/src/test/js/map/data/MapModel-test.js b/frontend-js/src/test/js/map/data/MapModel-test.js
index 7167805e1d..c39b391342 100644
--- a/frontend-js/src/test/js/map/data/MapModel-test.js
+++ b/frontend-js/src/test/js/map/data/MapModel-test.js
@@ -180,7 +180,7 @@ describe('MapModel', function() {
id : "(1.00,2.00)"
});
return model.getByIdentifiedElement(ie).then(function(element) {
- assert.ok(element instanceof PointData)
+ assert.ok(element instanceof PointData);
});
});
});
diff --git a/frontend-js/src/test/js/map/surface/AliasSurface-test.js b/frontend-js/src/test/js/map/surface/AliasSurface-test.js
index dfd8d9f070..03ff64034b 100644
--- a/frontend-js/src/test/js/map/surface/AliasSurface-test.js
+++ b/frontend-js/src/test/js/map/surface/AliasSurface-test.js
@@ -70,7 +70,7 @@ describe('AliasSurface', function() {
result.setBoundsForAlias(1, 3);
var bounds2 = result.getBounds();
assert.equal(bounds.getSouthWest().lat(), bounds2.getSouthWest().lat());
- assert.ok(bounds.getSouthWest().lng() != bounds2.getSouthWest().lng());
+ assert.ok(bounds.getSouthWest().lng() !== bounds2.getSouthWest().lng());
});
});
--
GitLab