diff --git a/CHANGELOG b/CHANGELOG index 81656787ed0d00e831ec78a868d305788fdc2b8a..7a2ede31e6197ba7724a59873f966db664d43bfb 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -21,6 +21,8 @@ minerva (14.0.0~beta.2) unstable; urgency=low create data overlay (#939) * Bug fix: export to CD could misalign reaction lines that were imported from format that didn't require reaction line to be attached to the species (#933) + * Bug fix: problem with uploading data_overlays with type included in header + (#936) -- Piotr Gawron <piotr.gawron@uni.lu> Mon, 16 Sep 2019 21:00:00 +0200 diff --git a/frontend-js/src/main/js/gui/AddOverlayDialog.js b/frontend-js/src/main/js/gui/AddOverlayDialog.js index e9d20fe7b0e2115e44e38828f21b71cdff976efe..c6a5b3fbb9258593146b5869645c659ccc6e1802 100644 --- a/frontend-js/src/main/js/gui/AddOverlayDialog.js +++ b/frontend-js/src/main/js/gui/AddOverlayDialog.js @@ -164,6 +164,7 @@ AddOverlayDialog.prototype.processFile = function (file) { } if (overlay.getType() !== undefined) { + var typeSelect = $("[name='overlay-type']", self.getElement())[0]; if ($("option[value='" + overlay.getType() + "']", typeSelect).length === 0) { GuiConnector.warn("Invalid type: " + overlay.getType()); } diff --git a/frontend-js/src/test/js/gui/AddOverlayDialog-test.js b/frontend-js/src/test/js/gui/AddOverlayDialog-test.js index 5ee5b21065af10119bda8e5ffa10f7dc1edaca6c..1618a2b1c81f39e94bca3205e2b422c02c0b7616 100644 --- a/frontend-js/src/test/js/gui/AddOverlayDialog-test.js +++ b/frontend-js/src/test/js/gui/AddOverlayDialog-test.js @@ -76,6 +76,19 @@ describe('AddOverlayDialog', function () { assert.equal("GENERIC", dialog.getType()); }); }); + it('set type from header', function () { + var dialog; + return ServerConnector.getProject().then(function (project) { + dialog = createDialog(project); + return dialog.init(); + }).then(function () { + return helper.stringToBlob("#TYPE=GENETIC_VARIANT\ns1\n"); + }).then(function (file) { + return dialog.processFile(file); + }).then(function () { + assert.equal("GENETIC_VARIANT", dialog.getType()); + }); + }); });