From 8b676577a429604f14e576081189f564335d3882 Mon Sep 17 00:00:00 2001
From: Piotr Gawron <piotr.gawron@uni.lu>
Date: Mon, 26 Aug 2019 17:00:16 +0200
Subject: [PATCH] new user must have not empty password defined
---
.../src/main/js/gui/admin/EditUserDialog.js | 5 +++++
.../src/test/js/gui/admin/EditUserDialog-test.js | 16 ++++++++++++++++
2 files changed, 21 insertions(+)
diff --git a/frontend-js/src/main/js/gui/admin/EditUserDialog.js b/frontend-js/src/main/js/gui/admin/EditUserDialog.js
index 53d9f99470..298c2e9dae 100644
--- a/frontend-js/src/main/js/gui/admin/EditUserDialog.js
+++ b/frontend-js/src/main/js/gui/admin/EditUserDialog.js
@@ -670,6 +670,11 @@ EditUserDialog.prototype.checkValidity = function () {
error += "<li>Password doesn't match</li>";
isValid = false;
}
+ if (self.getIsNewUser() && self.getPassword() === "") {
+ error += "<li>Password for the user is not defined</li>";
+ isValid = false;
+ }
+
if (self.getLogin() === "" || self.getLogin() === undefined) {
error += "<li>Login must not be empty</li>";
isValid = false;
diff --git a/frontend-js/src/test/js/gui/admin/EditUserDialog-test.js b/frontend-js/src/test/js/gui/admin/EditUserDialog-test.js
index 460ba24bb3..fffbc379b3 100644
--- a/frontend-js/src/test/js/gui/admin/EditUserDialog-test.js
+++ b/frontend-js/src/test/js/gui/admin/EditUserDialog-test.js
@@ -60,6 +60,22 @@ describe('EditUserDialog', function () {
});
});
+ it('new user without password', function () {
+ var user = new User({});
+ var dialog = createEditUserDialog(user);
+
+ return dialog.init().then(function () {
+ dialog.setLogin("x");
+ return dialog.checkValidity().then(function () {
+ assert.ok(null);
+ }, function (error) {
+ assert.ok(error instanceof ValidationError);
+ });
+ }).then(function () {
+ dialog.destroy();
+ });
+ });
+
it('too long user login', function () {
var dialog;
var user = new User({});
--
GitLab