Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Menu
Open sidebar
minerva
core
Commits
86be8a9c
Commit
86be8a9c
authored
Feb 24, 2020
by
Piotr Gawron
Browse files
Merge branch '1065-overlay-in-zip' into 'devel_14.0.x'
use file name as a name when necessary See merge request
!1066
parents
d7e9aad5
4ccfad90
Pipeline
#21410
passed with stage
in 13 minutes and 39 seconds
Changes
2
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
CHANGELOG
View file @
86be8a9c
...
...
@@ -8,6 +8,8 @@ minerva (14.0.9) stable; urgency=medium
reversible
even
though
they
were
not
visualized
so
(#
1109
)
*
Bug
fix
:
when
data
overlay
was
being
removed
user
could
request
to
remove
overlay
second
time
and
an
error
was
thrown
(#
1121
)
*
Bug
fix
:
when
data
overlay
name
in
zip
uploaded
zip
file
is
not
present
the
name
of
a
file
is
used
as
overlay
name
(#
1065
)
--
Piotr
Gawron
<
piotr
.
gawron
@
uni
.
lu
>
Mon
,
3
Feb
2020
15
:
00
:
00
+
0200
...
...
frontend-js/src/main/js/gui/admin/AddProjectDialog.js
View file @
86be8a9c
...
...
@@ -512,12 +512,6 @@ AddProjectDialog.prototype._createOverlayTable = function () {
var
entry
=
entries
[
i
];
if
(
entry
.
getType
()
===
"
OVERLAY
"
)
{
var
name
=
entry
.
getData
().
name
;
if
(
name
===
undefined
||
name
===
null
||
name
===
""
)
{
name
=
entry
.
getFilename
().
substring
(
0
,
entry
.
getFilename
().
lastIndexOf
(
'
.
'
));
if
(
name
.
indexOf
(
"
/
"
)
>=
0
)
{
name
=
name
.
substring
(
name
.
lastIndexOf
(
"
/
"
)
+
1
);
}
}
var
row
=
[];
row
[
0
]
=
entry
.
getFilename
();
...
...
@@ -1469,7 +1463,10 @@ AddProjectDialog.prototype.createZipEntry = function (jsZipEntry, zipObject) {
if
(
overlay
.
getName
())
{
data
.
name
=
overlay
.
getName
();
}
else
{
data
.
name
=
""
;
data
.
name
=
filename
.
substring
(
0
,
filename
.
lastIndexOf
(
'
.
'
));
if
(
data
.
name
.
indexOf
(
"
/
"
)
>=
0
)
{
data
.
name
=
data
.
name
.
substring
(
data
.
name
.
lastIndexOf
(
"
/
"
)
+
1
);
}
}
if
(
overlay
.
getDescription
())
{
data
.
description
=
overlay
.
getDescription
();
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment