From 6d379f36ec0ddaa62a1e657012eb96d0f3afdda8 Mon Sep 17 00:00:00 2001
From: Piotr Gawron <piotr.gawron@uni.lu>
Date: Thu, 25 Apr 2019 16:05:45 +0200
Subject: [PATCH] when plugin crash warning is printed in the console
---
frontend-js/src/main/js/plugin/MinervaPluginProxy.js | 2 ++
frontend-js/src/test/js/plugin/Plugin-test.js | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/frontend-js/src/main/js/plugin/MinervaPluginProxy.js b/frontend-js/src/main/js/plugin/MinervaPluginProxy.js
index feb8595972..2fb91faf48 100644
--- a/frontend-js/src/main/js/plugin/MinervaPluginProxy.js
+++ b/frontend-js/src/main/js/plugin/MinervaPluginProxy.js
@@ -588,12 +588,14 @@ function createProjectMap(options) {
try {
return Promise.resolve(listenerWrapper(e)).catch(function (error) {
GuiConnector.warn("Plugin " + options.plugin.getName() + " crashed");
+ logger.warn(error);
if (typeof options.plugin.getLoadedPluginData().notifyError === "function") {
options.plugin.getLoadedPluginData().notifyError({listener: param, data: e, error: error});
}
});
} catch (error) {
GuiConnector.warn("Plugin " + options.plugin.getName() + " crashed");
+ logger.warn(error);
if (typeof options.plugin.getLoadedPluginData().notifyError === "function") {
options.plugin.getLoadedPluginData().notifyError({listener: param, data: e, error: error});
}
diff --git a/frontend-js/src/test/js/plugin/Plugin-test.js b/frontend-js/src/test/js/plugin/Plugin-test.js
index ac0671033a..ca53c0674e 100644
--- a/frontend-js/src/test/js/plugin/Plugin-test.js
+++ b/frontend-js/src/test/js/plugin/Plugin-test.js
@@ -114,7 +114,7 @@ describe('Plugin', function () {
return plugin.load().then(function () {
return map.callListeners("onCenterChanged", new Point(0, 0));
}).then(function () {
- assert.equal(1, logger.getWarnings().length);
+ assert.equal(2, logger.getWarnings().length);
});
});
});
--
GitLab