From 52d9ef3c6df95ccccfdbe04c09253025e344e50e Mon Sep 17 00:00:00 2001
From: Piotr Gawron <piotr.gawron@uni.lu>
Date: Wed, 28 Aug 2019 21:10:40 +0200
Subject: [PATCH] verify overlay type in frontend
---
CHANGELOG | 3 ++-
frontend-js/src/main/js/gui/AddOverlayDialog.js | 3 +++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/CHANGELOG b/CHANGELOG
index cf175a2858..172c1bf8be 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -1,5 +1,6 @@
minerva (13.2.0) stable; urgency=medium
- * Bug fix:search by drugs didn't check synonyms in chembl database
+ * Bug fix: search by drugs didn't check synonyms in chembl database
+ * Bug fix: verification of overlay type added (#917)
-- Piotr Gawron <piotr.gawron@uni.lu> Wed, 21 Aug 2019 17:00:00 +0200
diff --git a/frontend-js/src/main/js/gui/AddOverlayDialog.js b/frontend-js/src/main/js/gui/AddOverlayDialog.js
index a11e5f5802..d4d0d5b233 100644
--- a/frontend-js/src/main/js/gui/AddOverlayDialog.js
+++ b/frontend-js/src/main/js/gui/AddOverlayDialog.js
@@ -163,6 +163,9 @@ AddOverlayDialog.prototype.processFile = function (file) {
descriptionInput.value = overlay.getDescription();
}
if (overlay.getType() !== undefined) {
+ if ($("option[value='" + overlay.getType() + "']", typeSelect).length === 0) {
+ GuiConnector.warn("Invalid type: " + overlay.getType());
+ }
typeSelect.val(overlay.getType());
}
if (overlayParser.containsMixedNewLineCharacters(evt.target.result)) {
--
GitLab