From 433bc44dbfb96775fb2097f1473cd4ac3ec67662 Mon Sep 17 00:00:00 2001 From: Piotr Gawron <piotr.gawron@uni.lu> Date: Fri, 19 May 2017 16:56:55 +0200 Subject: [PATCH] lint issues --- frontend-js/src/main/js/GuiConnector.js | 2 +- frontend-js/src/main/js/gui/leftPanel/AbstractDbPanel.js | 4 ++-- frontend-js/src/main/js/gui/leftPanel/OverlayPanel.js | 2 +- frontend-js/src/main/js/map/data/LayoutData.js | 2 +- frontend-js/src/main/js/minerva.js | 1 - frontend-js/src/test/js/minerva-test.js | 1 - 6 files changed, 5 insertions(+), 7 deletions(-) diff --git a/frontend-js/src/main/js/GuiConnector.js b/frontend-js/src/main/js/GuiConnector.js index c90b252dfc..002779bb62 100644 --- a/frontend-js/src/main/js/GuiConnector.js +++ b/frontend-js/src/main/js/GuiConnector.js @@ -59,7 +59,7 @@ GuiConnector.init = function() { for (var i = 0; i < self._windowResizeEvents.length; i++) { self._windowResizeEvents[i](); } - } + }; } }; diff --git a/frontend-js/src/main/js/gui/leftPanel/AbstractDbPanel.js b/frontend-js/src/main/js/gui/leftPanel/AbstractDbPanel.js index 4c7b937b7b..d32c39532e 100644 --- a/frontend-js/src/main/js/gui/leftPanel/AbstractDbPanel.js +++ b/frontend-js/src/main/js/gui/leftPanel/AbstractDbPanel.js @@ -61,7 +61,7 @@ AbstractPanel.prototype._createEventHandlers = function() { self.onresize(); }); - $("a[href='#"+self.getElement().id+"']").on('shown.bs.tab', function(e) { + $("a[href='#"+self.getElement().id+"']").on('shown.bs.tab', function() { self.onresize(); }); @@ -299,7 +299,7 @@ AbstractPanel.prototype.onresize = function() { $(".pre-scrollable", self.getElement()).each(function(index, element) { if ($(element).is(":visible")) { - size = Math.min(size, footerPosition - $(element).offset().top) + size = Math.min(size, footerPosition - $(element).offset().top); } }); if (size !== 100000) { diff --git a/frontend-js/src/main/js/gui/leftPanel/OverlayPanel.js b/frontend-js/src/main/js/gui/leftPanel/OverlayPanel.js index cfd2a9036c..85ebe5727a 100644 --- a/frontend-js/src/main/js/gui/leftPanel/OverlayPanel.js +++ b/frontend-js/src/main/js/gui/leftPanel/OverlayPanel.js @@ -31,7 +31,7 @@ function OverlayPanel(params) { self.onresize(); }); - $("a[href='#"+self.getElement().id+"']").on('shown.bs.tab', function(e) { + $("a[href='#"+self.getElement().id+"']").on('shown.bs.tab', function() { self.onresize(); }); diff --git a/frontend-js/src/main/js/map/data/LayoutData.js b/frontend-js/src/main/js/map/data/LayoutData.js index ad9a7d8e12..3275fc9312 100644 --- a/frontend-js/src/main/js/map/data/LayoutData.js +++ b/frontend-js/src/main/js/map/data/LayoutData.js @@ -172,7 +172,7 @@ LayoutData.prototype.init = function() { } else if (data[i] instanceof LayoutReaction) { self.addReaction(data[i]); } else { - reject("Unknown element type: " + typeof (data[i])); + return Promise.reject("Unknown element type: " + typeof (data[i])); } } diff --git a/frontend-js/src/main/js/minerva.js b/frontend-js/src/main/js/minerva.js index 81f69dcf9c..aea8e61910 100644 --- a/frontend-js/src/main/js/minerva.js +++ b/frontend-js/src/main/js/minerva.js @@ -136,7 +136,6 @@ function create(params) { params = new CustomMapOptions(params); } - var project = params.getProject(); var element = params.getElement(); if (global.GuiConnector === undefined) { diff --git a/frontend-js/src/test/js/minerva-test.js b/frontend-js/src/test/js/minerva-test.js index c525eeba34..1b3bce17fc 100644 --- a/frontend-js/src/test/js/minerva-test.js +++ b/frontend-js/src/test/js/minerva-test.js @@ -10,7 +10,6 @@ var Project = require('../../main/js/map/data/Project'); var chai = require('chai'); var assert = chai.assert; var logger = require('./logger'); -var Functions = require('../../main/js/Functions'); describe('minerva global', function() { -- GitLab