Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Menu
Open sidebar
minerva
core
Commits
3515cb67
Commit
3515cb67
authored
Jan 15, 2020
by
Piotr Gawron
Browse files
Merge branch '1073-plugin-url-verification' into 'devel_14.0.x'
url must be unique See merge request
!1043
parents
e8b441c0
37a03a7a
Pipeline
#19494
failed with stage
in 3 minutes and 14 seconds
Changes
3
Pipelines
4
Hide whitespace changes
Inline
Side-by-side
model/src/main/java/lcsb/mapviewer/model/plugin/Plugin.java
View file @
3515cb67
...
...
@@ -106,4 +106,11 @@ public class Plugin implements Serializable {
public
void
setPublic
(
boolean
isPublic
)
{
this
.
isPublic
=
isPublic
;
}
public
void
addUrl
(
String
string
)
{
if
(!
urls
.
contains
(
string
))
{
urls
.
add
(
string
);
}
}
}
persist/src/test/java/lcsb/mapviewer/persist/dao/plugin/PluginDaoTest.java
View file @
3515cb67
...
...
@@ -24,9 +24,22 @@ public class PluginDaoTest extends PersistTestFunctions {
plugin
.
setHash
(
"x"
);
plugin
.
setName
(
"Plugin name"
);
plugin
.
setVersion
(
"0.0.1"
);
plugin
.
getUrls
().
add
(
"htpp://google.pl/"
);
plugin
.
add
Url
(
"htpp://google.pl/"
);
pluginDao
.
add
(
plugin
);
assertTrue
(
pluginDao
.
getAll
().
size
()
>
0
);
}
@Test
public
void
testAddPluginWithUrls
()
{
Plugin
plugin
=
new
Plugin
();
plugin
.
setHash
(
"x"
);
plugin
.
setName
(
"Plugin name"
);
plugin
.
setVersion
(
"0.0.1"
);
plugin
.
addUrl
(
"htpp://google.pl/"
);
plugin
.
addUrl
(
"htpp://google.pl/"
);
pluginDao
.
add
(
plugin
);
pluginDao
.
flush
();
assertTrue
(
pluginDao
.
getAll
().
size
()
>
0
);
}
}
rest-api/src/main/java/lcsb/mapviewer/api/plugins/PluginRestImpl.java
View file @
3515cb67
...
...
@@ -34,7 +34,7 @@ public class PluginRestImpl extends BaseRestImpl {
}
Plugin
plugin
=
pluginDao
.
getByHash
(
hash
);
if
(
plugin
!=
null
)
{
plugin
.
getUrls
().
add
(
url
);
plugin
.
add
Url
(
url
);
plugin
.
setPublic
(
plugin
.
isPublic
()
||
isPublic
);
pluginDao
.
update
(
plugin
);
}
else
{
...
...
@@ -44,7 +44,7 @@ public class PluginRestImpl extends BaseRestImpl {
plugin
.
setVersion
(
version
);
plugin
.
setPublic
(
isPublic
);
if
(!
url
.
isEmpty
())
{
plugin
.
getUrls
().
add
(
url
);
plugin
.
add
Url
(
url
);
}
pluginDao
.
add
(
plugin
);
}
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment