Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Menu
Gitlab will go into maintenance Friday 3rd February from 9:00 to 10:00
Open sidebar
minerva
core
Commits
2dffc17a
Commit
2dffc17a
authored
Apr 03, 2019
by
Piotr Gawron
Browse files
login is properly escaped
parent
49b185da
Pipeline
#9627
failed with stage
in 16 minutes and 27 seconds
Changes
4
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
CHANGELOG
View file @
2dffc17a
...
...
@@ -5,6 +5,8 @@ minerva (12.2.2) stable; urgency=medium
ordered overlays (#777)
* Bug fix: chemical search didn'
t
use
updated
disease
identifier
,
original
disease
id
from
project
upload
was
used
instead
(#
779
)
*
Bug
fix
:
user
login
with
special
characters
(
like
'@'
)
could
cause
problems
in
admin
panel
(#
780
)
minerva
(
12.2.1
)
stable
;
urgency
=
medium
*
Bug
fix
:
export
of
reaction
colorsi
in
SBML
is
properly
encoded
(
COPASI
can
...
...
frontend-js/src/main/js/gui/admin/EditProjectDialog.js
View file @
2dffc17a
...
...
@@ -1017,8 +1017,6 @@ EditProjectDialog.prototype.saveOverlay = function (overlayId) {
overlay
.
setCreator
(
creator
);
overlay
.
setOrder
(
order
);
}
console
.
log
(
"
output
"
);
console
.
log
(
overlay
);
return
self
.
getServerConnector
().
updateOverlay
(
overlay
);
};
...
...
frontend-js/src/main/js/gui/admin/UsersAdminPanel.js
View file @
2dffc17a
...
...
@@ -299,7 +299,7 @@ UsersAdminPanel.prototype.addUpdateListener = function (user, dataTableRow) {
}
}
var
listener
=
function
()
{
var
login
=
user
.
getLogin
().
replace
(
"
.
"
,
"
\\
.
"
);
var
login
=
$
.
escapeSelector
(
user
.
getLogin
()
);
self
.
userToTableRow
(
user
,
dataTableRow
);
var
row
=
$
(
$
(
"
[name='usersTable']
"
,
self
.
getElement
())[
0
]).
DataTable
().
row
(
"
#
"
+
login
);
if
(
row
.
length
>
0
)
{
...
...
frontend-js/src/test/js/gui/admin/UserAdminPanel-test.js
View file @
2dffc17a
...
...
@@ -102,6 +102,18 @@ describe('UsersAdminPanel', function () {
});
});
it
(
'
onUpdateUserListener
'
,
function
()
{
helper
.
loginAsAdmin
();
var
usersTab
=
createUserAdminPanel
();
return
usersTab
.
init
().
then
(
function
()
{
var
user
=
helper
.
createUser
();
user
.
setLogin
(
"
x@y.lu
"
);
var
data
=
[];
usersTab
.
addUpdateListener
(
user
,
data
);
user
.
callListeners
(
"
onreload
"
);
assert
.
ok
(
data
.
indexOf
(
"
x@y.lu
"
)
>=
0
);
return
usersTab
.
destroy
();
});
});
})
;
});
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment