From 05a0881ec02d7e9189276c89c8035d871efb9027 Mon Sep 17 00:00:00 2001
From: Piotr Gawron <piotr.gawron@uni.lu>
Date: Mon, 1 Oct 2018 16:59:34 +0200
Subject: [PATCH] unit tests simplified
---
.../test/js/gui/admin/MapsAdminPanel-test.js | 39 ++++++-------------
1 file changed, 12 insertions(+), 27 deletions(-)
diff --git a/frontend-js/src/test/js/gui/admin/MapsAdminPanel-test.js b/frontend-js/src/test/js/gui/admin/MapsAdminPanel-test.js
index 1b3a505b23..970db1e3b3 100644
--- a/frontend-js/src/test/js/gui/admin/MapsAdminPanel-test.js
+++ b/frontend-js/src/test/js/gui/admin/MapsAdminPanel-test.js
@@ -8,10 +8,10 @@ var logger = require('../../logger');
var assert = require('assert');
-function createMapsAdminPanel(configuration) {
+function createMapsAdminPanel() {
return new MapsAdminPanel({
element: testDiv,
- configuration: configuration,
+ configuration: helper.getConfiguration(),
serverConnector: ServerConnector
});
}
@@ -19,11 +19,8 @@ function createMapsAdminPanel(configuration) {
describe('MapsAdminPanel', function () {
it('refresh', function () {
- var mapTab;
- return ServerConnector.getConfiguration().then(function (configuration) {
- mapTab = createMapsAdminPanel(configuration);
- return mapTab.init();
- }).then(function () {
+ var mapTab = createMapsAdminPanel();
+ return mapTab.init().then(function () {
return mapTab.onRefreshClicked();
}).then(function () {
assert.equal(0, logger.getWarnings().length);
@@ -31,11 +28,8 @@ describe('MapsAdminPanel', function () {
});
});
it('showLogs', function () {
- var mapTab;
- return ServerConnector.getConfiguration().then(function (configuration) {
- mapTab = createMapsAdminPanel(configuration);
- return mapTab.init();
- }).then(function () {
+ var mapTab = createMapsAdminPanel();
+ return mapTab.init().then(function () {
return mapTab.showLogs("sample", 'error');
}).then(function () {
assert.equal(0, logger.getWarnings().length);
@@ -45,11 +39,8 @@ describe('MapsAdminPanel', function () {
it('getDialog', function () {
helper.loginAsAdmin();
- var mapTab;
- return ServerConnector.getConfiguration().then(function (configuration) {
- mapTab = createMapsAdminPanel(configuration);
- return mapTab.init();
- }).then(function () {
+ var mapTab = createMapsAdminPanel();
+ return mapTab.init().then(function () {
return ServerConnector.getProject();
}).then(function (project) {
return mapTab.getDialog(project);
@@ -62,22 +53,16 @@ describe('MapsAdminPanel', function () {
describe('onAddClicked', function () {
it('default', function () {
- var mapTab;
- return ServerConnector.getConfiguration().then(function (configuration) {
- mapTab = createMapsAdminPanel(configuration);
- return mapTab.init();
- }).then(function () {
+ var mapTab = createMapsAdminPanel();
+ return mapTab.init().then(function () {
return mapTab.onAddClicked();
}).then(function () {
return mapTab.destroy();
});
});
it('close and reopen', function () {
- var mapTab;
- return ServerConnector.getConfiguration().then(function (configuration) {
- mapTab = createMapsAdminPanel(configuration);
- return mapTab.init();
- }).then(function () {
+ var mapTab = createMapsAdminPanel();
+ return mapTab.init().then(function () {
return mapTab.onAddClicked();
}).then(function () {
mapTab._addDialog.close();
--
GitLab