Merge pull request #126 from giordano/mg/operation-return-value

Fix checking of errors in `libsbml_convert`

Merge pull request #126 from giordano/mg/operation-return-value
Fix checking of errors in `libsbml_convert`
63c09484 · Miroslav Kratochvil · GitHub · 68e0e0b5 · fa4446f0 · 63c09484
Unverified Commit 63c09484 authored Jul 19, 2021 by Miroslav Kratochvil Committed by GitHub Jul 19, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

src/converters.jl src/converters.jl +3 -1

No files found.
--- a/src/converters.jl
+++ b/src/converters.jl
@@ -46,7 +46,9 @@ libsbml_convert(
                )
            end
            check_errors(
-                ccall(sbml(:SBMLDocument_convert), Cint, (VPtr, VPtr), doc, props),
+                # `SBMLDocument_convert` returns `LIBSBML_OPERATION_SUCCESS` (== 0) for a
+                # successful operation, something else when there is a failure.
+                iszero(ccall(sbml(:SBMLDocument_convert), Cint, (VPtr, VPtr), doc, props)),
                doc,
                ErrorException("Conversion returned errors"),
            )