fixed reviews

src/analysis/flux_variability_analysis.jl

@@ -141,7 +141,7 @@ Internal helper for creating the optimized model on a remote worker, for
 avoiding namespace problems.
 """
 function _FVA_optimize_reaction(model, rid, ret)
-    sense = rid > 0 ? MAX : MIN
+    sense = rid > 0 ? MAX_SENSE : MIN_SENSE
     var = all_variables(model)[abs(rid)]
 
     @objective(model, sense, var)

src/base/constants.jl

@@ -53,5 +53,5 @@ const _constants = (
     colors = (empty = :dark_gray, payload = :default, key = :cyan),
 )
 
-const MAX = COBREXA.MOI.MAX_SENSE
-const MIN = COBREXA.MOI.MIN_SENSE
+const MAX_SENSE = COBREXA.MOI.MAX_SENSE
+const MIN_SENSE = COBREXA.MOI.MIN_SENSE

test/analysis/flux_balance_analysis.jl

@@ -56,7 +56,7 @@ end
         modifications = [
             change_objective("BIOMASS_Ecoli_core_w_GAM"),
             change_constraint("EX_glc__D_e", -12, -12),
-            change_sense(MOI.MAX_SENSE),
+            change_sense(MAX_SENSE),
             change_optimizer_attribute("IPM_IterationsLimit", 110),
         ],
     )