From d0fb30593354c8323a5f0210ce04186697df59d3 Mon Sep 17 00:00:00 2001
From: nkindlon <nek3d@virginia.edu>
Date: Thu, 6 Feb 2014 07:42:19 -0500
Subject: [PATCH] Removed unnecessary NULL checks on delete.
---
src/sampleFile/SampleFile.cpp | 11 +--
.../FileReaders/BamFileReader.cpp | 29 +------
.../FileReaders/BamFileReader.h | 1 -
.../FileReaders/BufferedStreamMgr.cpp | 12 ++-
.../FileReaders/InputStreamMgr.cpp | 77 ++++++-------------
.../SingleLineDelimTextFileReader.cpp | 1 +
src/utils/FileRecordTools/FileRecordMgr.cpp | 35 ++++-----
src/utils/NewChromsweep/NewChromsweep.cpp | 12 +--
8 files changed, 53 insertions(+), 125 deletions(-)
diff --git a/src/sampleFile/SampleFile.cpp b/src/sampleFile/SampleFile.cpp
index 8f532c5f..8291824c 100644
--- a/src/sampleFile/SampleFile.cpp
+++ b/src/sampleFile/SampleFile.cpp
@@ -35,11 +35,7 @@ SampleFile::~SampleFile() {
bool SampleFile::takeSample()
{
//we're only operating on one file, so the idx is zero.
- _inputFile = new FileRecordMgr(0, _context);
- if (!_inputFile->open()) {
- return false; // FRM will give the error and die anyway,
- //no error message needed here.
- }
+ _inputFile = _context->getFile(0);
_samples.resize(_numSamples, NULL);
@@ -50,7 +46,6 @@ bool SampleFile::takeSample()
_context->getUnspecifiedSeed();
}
- _context->determineOutputType();
_outputMgr = new RecordOutputMgr();
_outputMgr->init(_context);
@@ -82,10 +77,6 @@ bool SampleFile::takeSample()
}
delete _outputMgr;
_inputFile->close();
-
- //clean up.
- delete _inputFile;
-
return true;
}
diff --git a/src/utils/FileRecordTools/FileReaders/BamFileReader.cpp b/src/utils/FileRecordTools/FileReaders/BamFileReader.cpp
index a9d129d7..ab717f92 100644
--- a/src/utils/FileRecordTools/FileReaders/BamFileReader.cpp
+++ b/src/utils/FileRecordTools/FileReaders/BamFileReader.cpp
@@ -4,44 +4,17 @@
BamFileReader::BamFileReader()
: _bamReader(NULL),
_eof(false),
- _useTags(true),
- _shouldDeleteBamReader(false)
+ _useTags(true)
{
}
BamFileReader::~BamFileReader()
{
- if (_bamReader != NULL && _shouldDeleteBamReader) {
- delete _bamReader;
- _shouldDeleteBamReader = false;
- _bamReader = NULL;
- }
}
bool BamFileReader::open()
{
-// if (_bamReader == NULL) {
-// _bamReader = new BamTools::BamReader();
-// _shouldDeleteBamReader = true;
-// }
-// if (_inputStream != NULL) {
-// try {
-// _bamReader->OpenStream(_inputStream);
-// }
-// catch (...) {
-// fprintf(stderr, "ERROR: Unable to open BAM file from standard input.\n");
-// exit(1);
-// }
-// } else {
-// try {
-// _bamReader->Open(_filename);
-// }
-// catch (...) {
-// fprintf(stderr, "ERROR: Unable to open BAM file %s\n", _filename.c_str());
-// exit(1);
-// }
-// }
_bamHeader = _bamReader->GetHeaderText();
_references = _bamReader->GetReferenceData();
diff --git a/src/utils/FileRecordTools/FileReaders/BamFileReader.h b/src/utils/FileRecordTools/FileReaders/BamFileReader.h
index e9861b9e..8bea945e 100644
--- a/src/utils/FileRecordTools/FileReaders/BamFileReader.h
+++ b/src/utils/FileRecordTools/FileReaders/BamFileReader.h
@@ -58,7 +58,6 @@ protected:
QuickString _bamHeader;
BamTools::RefVector _references;
bool _useTags;
- bool _shouldDeleteBamReader;
static const int MINIMUM_PRINTABLE_BAM_FIELDS = 6;
void extractNameFromCore();
diff --git a/src/utils/FileRecordTools/FileReaders/BufferedStreamMgr.cpp b/src/utils/FileRecordTools/FileReaders/BufferedStreamMgr.cpp
index 55ec8865..27f07894 100644
--- a/src/utils/FileRecordTools/FileReaders/BufferedStreamMgr.cpp
+++ b/src/utils/FileRecordTools/FileReaders/BufferedStreamMgr.cpp
@@ -26,13 +26,11 @@ BufferedStreamMgr::BufferedStreamMgr(const QuickString &filename)
BufferedStreamMgr::~BufferedStreamMgr()
{
- if (_mainBuf != NULL) {
- delete [] _mainBuf;
- }
- if (_inputStreamMgr != NULL) {
- delete _inputStreamMgr;
- _inputStreamMgr = NULL;
- }
+ delete [] _mainBuf;
+ _mainBuf = NULL;
+
+ delete _inputStreamMgr;
+ _inputStreamMgr = NULL;
}
bool BufferedStreamMgr::init()
diff --git a/src/utils/FileRecordTools/FileReaders/InputStreamMgr.cpp b/src/utils/FileRecordTools/FileReaders/InputStreamMgr.cpp
index 5b1d0a9c..2035b9c6 100644
--- a/src/utils/FileRecordTools/FileReaders/InputStreamMgr.cpp
+++ b/src/utils/FileRecordTools/FileReaders/InputStreamMgr.cpp
@@ -35,38 +35,29 @@ InputStreamMgr::InputStreamMgr(const QuickString &filename, bool buildScanBuffer
InputStreamMgr::~InputStreamMgr() {
- if (_pushBackStreamBuf != NULL) {
- delete _pushBackStreamBuf;
- _pushBackStreamBuf = NULL;
- }
- if (_inputFileStream != NULL) {
- delete _inputFileStream;
- _inputFileStream = NULL;
- }
- if (_oldInputStream != NULL) {
- delete _oldInputStream;
- _oldInputStream = NULL;
- }
- if (_infStreamBuf != NULL) {
- delete _infStreamBuf;
- _infStreamBuf = NULL;
- }
- if (_bamReader != NULL) {
- delete _bamReader;
- _bgStream = NULL;
- }
- if (_bgStream != NULL) {
- delete _bgStream;
- _bgStream = NULL;
- }
- if (_finalInputStream != NULL) {
- delete _finalInputStream;
- _finalInputStream = NULL;
- }
- if (_tmpZipBuf != NULL) {
- delete [] _tmpZipBuf;
- _tmpZipBuf = NULL;
- }
+ delete _pushBackStreamBuf;
+ _pushBackStreamBuf = NULL;
+
+ delete _inputFileStream;
+ _inputFileStream = NULL;
+
+ delete _oldInputStream;
+ _oldInputStream = NULL;
+
+ delete _infStreamBuf;
+ _infStreamBuf = NULL;
+
+ delete _bamReader;
+ _bgStream = NULL;
+
+ delete _bgStream;
+ _bgStream = NULL;
+
+ delete _finalInputStream;
+ _finalInputStream = NULL;
+
+ delete [] _tmpZipBuf;
+ _tmpZipBuf = NULL;
}
bool InputStreamMgr::init()
@@ -98,7 +89,6 @@ bool InputStreamMgr::init()
//now we have a PushBackStreamBuf. Make a new stream.
_finalInputStream = new istream(_pushBackStreamBuf);
populateScanBuffer();
-// resetStream();
return true;
}
@@ -240,9 +230,7 @@ bool InputStreamMgr::detectBamOrBgzip(int &numChars, int currChar)
_bamRuledOut = true;
_numBytesInBuffer = 0;
_infStreamBuf = new InflateStreamBuf(_finalInputStream);
- if (_oldInputStream != NULL) {
- delete _oldInputStream;
- }
+ delete _oldInputStream;
_oldInputStream = _finalInputStream;
_finalInputStream = new istream(_infStreamBuf);
return false;
@@ -251,23 +239,6 @@ bool InputStreamMgr::detectBamOrBgzip(int &numChars, int currChar)
return false;
}
-//void InputStreamMgr::decompressBuffer()
-//{
-// //allocate an array to hold uncompressed data.
-// _saveDataStr.clear();
-// uInt maxDecompressSize = 20 * _numBytesInBuffer;
-// unsigned char *newScanBuffer = new unsigned char[maxDecompressSize];
-// memset(newScanBuffer, 0, maxDecompressSize);
-//
-// unsigned int numDecompressChars = inflateGzippedArray(_scanBuffer, newScanBuffer, maxDecompressSize, _numBytesInBuffer);
-//
-// // newScanBuffer should now contain uncompressed data.
-// //delete old buffer, point it at new buffer.
-// _saveDataStr.append((char *)newScanBuffer, numDecompressChars);
-//
-// delete [] newScanBuffer;
-//}
-
void InputStreamMgr::readZipChunk()
{
if (_tmpZipBuf == NULL) {
diff --git a/src/utils/FileRecordTools/FileReaders/SingleLineDelimTextFileReader.cpp b/src/utils/FileRecordTools/FileReaders/SingleLineDelimTextFileReader.cpp
index 12739abe..38074edf 100644
--- a/src/utils/FileRecordTools/FileReaders/SingleLineDelimTextFileReader.cpp
+++ b/src/utils/FileRecordTools/FileReaders/SingleLineDelimTextFileReader.cpp
@@ -16,6 +16,7 @@ SingleLineDelimTextFileReader::SingleLineDelimTextFileReader(int numFields, char
SingleLineDelimTextFileReader::~SingleLineDelimTextFileReader()
{
delete [] _delimPositions;
+ _delimPositions = NULL;
}
bool SingleLineDelimTextFileReader::readEntry()
diff --git a/src/utils/FileRecordTools/FileRecordMgr.cpp b/src/utils/FileRecordTools/FileRecordMgr.cpp
index 8b3c2cad..38fc056b 100644
--- a/src/utils/FileRecordTools/FileRecordMgr.cpp
+++ b/src/utils/FileRecordTools/FileRecordMgr.cpp
@@ -30,19 +30,15 @@ FileRecordMgr::FileRecordMgr(const QuickString &filename, bool isSorted)
FileRecordMgr::~FileRecordMgr(){
- if (_bufStreamMgr != NULL) {
- delete _bufStreamMgr;
- _bufStreamMgr = NULL;
- }
- if (_fileReader != NULL) {
- close(); //just make sure file was closed.
- delete _fileReader;
- _fileReader = NULL;
- }
- if (_recordMgr != NULL) {
- delete _recordMgr;
- _recordMgr = NULL;
- }
+ delete _bufStreamMgr;
+ _bufStreamMgr = NULL;
+
+ close(); //just make sure file was closed.
+ delete _fileReader;
+ _fileReader = NULL;
+
+ delete _recordMgr;
+ _recordMgr = NULL;
}
bool FileRecordMgr::open(){
@@ -78,10 +74,9 @@ bool FileRecordMgr::open(){
}
void FileRecordMgr::close(){
- if (_bufStreamMgr != NULL) {
- delete _bufStreamMgr;
- _bufStreamMgr = NULL;
- }
+ delete _bufStreamMgr;
+ _bufStreamMgr = NULL;
+
if (_fileReader != NULL) {
_fileReader->close();
delete _fileReader;
@@ -91,7 +86,6 @@ void FileRecordMgr::close(){
bool FileRecordMgr::eof(){
return _fileReader->eof();
-// return _storedRecords.empty() && _fileReader->eof() ? true: false;
}
Record *FileRecordMgr::allocateAndGetNextRecord()
@@ -109,8 +103,9 @@ Record *FileRecordMgr::allocateAndGetNextRecord()
return NULL;
}
- // In the rare case of Bam records where both the read and it's mate failed to map,
- // Ignore the record. Delete and return null.
+ // If the record is unmapped, don't test for valid coords or sort order,
+ // but still return it so the -v (noHit) option and the like will still
+ // see it.
if (!record->isUnmapped()) {
if (!record->coordsValid()) {
diff --git a/src/utils/NewChromsweep/NewChromsweep.cpp b/src/utils/NewChromsweep/NewChromsweep.cpp
index 14e9a908..5e6045be 100644
--- a/src/utils/NewChromsweep/NewChromsweep.cpp
+++ b/src/utils/NewChromsweep/NewChromsweep.cpp
@@ -68,12 +68,12 @@ NewChromSweep::~NewChromSweep(void) {
if (!_wasInitialized) {
return;
}
- if (_currQueryRec != NULL) {
- _queryFRM->deleteRecord(_currQueryRec);
- }
- if (_currDatabaseRec != NULL) {
- _databaseFRM->deleteRecord(_currDatabaseRec);
- }
+ _queryFRM->deleteRecord(_currQueryRec);
+ _currQueryRec = NULL;
+
+ _databaseFRM->deleteRecord(_currDatabaseRec);
+ _currDatabaseRec = NULL;
+
_queryFRM->close();
_databaseFRM->close();
}
--
GitLab